feat: export glb#1741
Merged
Merged
Conversation
- get round info + test - get closest separation (body to body) + test
- wip design insert file with body names
- face get color efficiency fix - body export_gltf for exporting single bodies
… feat/workflow_10_additions
- activated MeasurementTools for CoreService - refactored intersecting bounding boxes to meet standards - abstracted color conversion to hex to auxiliary method - added tests for all features
…/pyansys-geometry into feat/workflow_10_additions
…/pyansys-geometry into feat/export_gltf
added various tests to verify
experiment with edge plotting
… feat/export_glb # Conflicts: # doc/changelog.d/1732.added.md # pyproject.toml # src/ansys/geometry/core/designer/face.py # src/ansys/geometry/core/math/bbox.py # src/ansys/geometry/core/modeler.py # src/ansys/geometry/core/tools/measurement_tools.py # tests/integration/test_design.py # tests/integration/test_geometry_commands.py # tests/integration/test_measurement_tools.py # tests/integration/test_plotter.py # tests/test_math.py
…eometry into feat/export_glb # Conflicts: # src/ansys/geometry/core/designer/face.py
RobPasMue
reviewed
Feb 14, 2025
RobPasMue
reviewed
Feb 14, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1741 +/- ##
==========================================
+ Coverage 90.87% 90.89% +0.02%
==========================================
Files 92 92
Lines 8198 8217 +19
==========================================
+ Hits 7450 7469 +19
Misses 748 748 ☔ View full report in Codecov by Sentry. |
jonahrb
approved these changes
Feb 14, 2025
This was referenced Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added plotting method to export model as a *.glb file.
Added associated tests with various colors and shapes.
Issue linked
Checklist
feat: extrude circle to cylinder)