Skip to content

feat: export glb#1741

Merged
jacobrkerstetter merged 32 commits into
mainfrom
feat/export_gltf
Feb 14, 2025
Merged

feat: export glb#1741
jacobrkerstetter merged 32 commits into
mainfrom
feat/export_gltf

Conversation

@jacobrkerstetter
Copy link
Copy Markdown
Contributor

@jacobrkerstetter jacobrkerstetter commented Feb 11, 2025

Description

Added plotting method to export model as a *.glb file.
Added associated tests with various colors and shapes.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

jacobrkerstetter and others added 21 commits January 31, 2025 11:30
- get round info + test
- get closest separation (body to body) + test
- wip design insert file with body names
implemented face colors
working on coloring tessellations
- face get color efficiency fix
- body export_gltf for exporting single bodies
- activated MeasurementTools for CoreService
- refactored intersecting bounding boxes to meet standards
- abstracted color conversion to hex to auxiliary method
- added tests for all features
@github-actions github-actions Bot added maintenance Package and maintenance related testing Anything related to tests labels Feb 11, 2025
@github-actions github-actions Bot added the enhancement New features or code improvements label Feb 11, 2025
@jacobrkerstetter jacobrkerstetter marked this pull request as draft February 14, 2025 14:40
… feat/export_glb

# Conflicts:
#	doc/changelog.d/1732.added.md
#	pyproject.toml
#	src/ansys/geometry/core/designer/face.py
#	src/ansys/geometry/core/math/bbox.py
#	src/ansys/geometry/core/modeler.py
#	src/ansys/geometry/core/tools/measurement_tools.py
#	tests/integration/test_design.py
#	tests/integration/test_geometry_commands.py
#	tests/integration/test_measurement_tools.py
#	tests/integration/test_plotter.py
#	tests/test_math.py
…eometry into feat/export_glb

# Conflicts:
#	src/ansys/geometry/core/designer/face.py
@github-actions github-actions Bot removed maintenance Package and maintenance related testing Anything related to tests labels Feb 14, 2025
Comment thread src/ansys/geometry/core/plotting/plotter.py
@github-actions github-actions Bot added the maintenance Package and maintenance related label Feb 14, 2025
Comment thread pyproject.toml
@jacobrkerstetter jacobrkerstetter marked this pull request as ready for review February 14, 2025 16:12
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.89%. Comparing base (be66ad2) to head (178e990).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/plotting/plotter.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1741      +/-   ##
==========================================
+ Coverage   90.87%   90.89%   +0.02%     
==========================================
  Files          92       92              
  Lines        8198     8217      +19     
==========================================
+ Hits         7450     7469      +19     
  Misses        748      748              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) February 14, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants