Skip to content

chore: enhancements to GLB export and object plot() methods#1750

Merged
RobPasMue merged 5 commits into
mainfrom
chore/improvements-to-glb-export
Feb 17, 2025
Merged

chore: enhancements to GLB export and object plot() methods#1750
RobPasMue merged 5 commits into
mainfrom
chore/improvements-to-glb-export

Conversation

@RobPasMue

Copy link
Copy Markdown
Member

Description

Follow up of #1741 - enhancing input variables and internal logic for defaults.

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Feb 17, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner February 17, 2025 08:40
@github-actions github-actions Bot added the maintenance Package and maintenance related label Feb 17, 2025
@codecov

codecov Bot commented Feb 17, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.86%. Comparing base (9a67dea) to head (d79b643).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/plotting/plotter.py 80.95% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1750      +/-   ##
==========================================
- Coverage   90.89%   90.86%   -0.03%     
==========================================
  Files          92       92              
  Lines        8217     8236      +19     
==========================================
+ Hits         7469     7484      +15     
- Misses        748      752       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue changed the title chore: enhancements to GLB export chore: enhancements to GLB export and object plot() methods Feb 17, 2025
@RobPasMue RobPasMue merged commit c04ef26 into main Feb 17, 2025
@RobPasMue RobPasMue deleted the chore/improvements-to-glb-export branch February 17, 2025 13:16
Comment thread src/ansys/geometry/core/plotting/plotter.py
RobPasMue added a commit that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants