feat: allow plotting of individual faces#1757
Merged
Merged
Conversation
9 tasks
RobPasMue
commented
Feb 18, 2025
MaxJPRey
reviewed
Feb 18, 2025
MaxJPRey
reviewed
Feb 18, 2025
MaxJPRey
previously approved these changes
Feb 18, 2025
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1757 +/- ##
==========================================
- Coverage 90.87% 90.85% -0.02%
==========================================
Files 92 92
Lines 8242 8271 +29
==========================================
+ Hits 7490 7515 +25
- Misses 752 756 +4 ☔ View full report in Codecov by Sentry. |
Contributor
|
Nice @RobPasMue . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Faces now have the option to be plotted individually and can be added to a
GeometryPlotteras well. Service colors are also handled properly. Also, issues with face colorings are solved from now onwards since the face tessellations are stored individually and we can search for the correct one.Issue linked
Closes #1705 and other related issues with #1741 #1732
Checklist
feat: extrude circle to cylinder)