Skip to content

feat: allow plotting of individual faces#1757

Merged
RobPasMue merged 5 commits into
mainfrom
feat/allow-face-plotting
Feb 18, 2025
Merged

feat: allow plotting of individual faces#1757
RobPasMue merged 5 commits into
mainfrom
feat/allow-face-plotting

Conversation

@RobPasMue

Copy link
Copy Markdown
Member

Description

Faces now have the option to be plotted individually and can be added to a GeometryPlotter as well. Service colors are also handled properly. Also, issues with face colorings are solved from now onwards since the face tessellations are stored individually and we can search for the correct one.

Issue linked

Closes #1705 and other related issues with #1741 #1732

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Feb 18, 2025
@RobPasMue
RobPasMue requested a review from a team as a code owner February 18, 2025 13:24
@github-actions github-actions Bot added the enhancement New features or code improvements label Feb 18, 2025
b-matteo
b-matteo previously approved these changes Feb 18, 2025

@b-matteo b-matteo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/ansys/geometry/core/designer/face.py Outdated
Comment thread src/ansys/geometry/core/designer/face.py Outdated
Comment thread src/ansys/geometry/core/designer/face.py Outdated
MaxJPRey
MaxJPRey previously approved these changes Feb 18, 2025
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
@codecov

codecov Bot commented Feb 18, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.85%. Comparing base (fd2a460) to head (f795ee8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/plotting/plotter.py 77.77% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1757      +/-   ##
==========================================
- Coverage   90.87%   90.85%   -0.02%     
==========================================
  Files          92       92              
  Lines        8242     8271      +29     
==========================================
+ Hits         7490     7515      +25     
- Misses        752      756       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue
RobPasMue merged commit 5bd252a into main Feb 18, 2025
@RobPasMue
RobPasMue deleted the feat/allow-face-plotting branch February 18, 2025 14:42
@MaxJPRey

Copy link
Copy Markdown
Contributor

Nice @RobPasMue .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to display faces using Geometry plotter

4 participants