feat: named selection functionality - #1768
Merged
Merged
Conversation
need read existing design functionality
implemented MoveRotate and MoveTranslate for named selections
jacobrkerstetter
changed the title
jacobrkerstetter
marked this pull request as ready for review
February 24, 2025 16:20
RobPasMue
requested changes
Feb 25, 2025
- fixed logic for creating new NS so the create command is only called once
…om/ansys/pyansys-geometry into feat/named_selection_functionality
- added more rigorous testing by querying a face for area - altered how the face/body/edge objects are populated for NS
…om/ansys/pyansys-geometry into feat/named_selection_functionality
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1768 +/- ##
==========================================
+ Coverage 90.88% 90.90% +0.02%
==========================================
Files 92 92
Lines 8357 8422 +65
==========================================
+ Hits 7595 7656 +61
- Misses 762 766 +4 ☔ View full report in Codecov by Sentry. |
RobPasMue
reviewed
Feb 27, 2025
RobPasMue
left a comment
RobPasMue
left a comment
Member
There was a problem hiding this comment.
This is looking really good! Left some comments, request review again once addressed
- adjusted import test for new model - added Quantity input type for new geometry commands - adjusted NamedSelection constructor -- beams still a question
…om/ansys/pyansys-geometry into feat/named_selection_functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue linked
Checklist
feat: extrude circle to cylinder)