Skip to content

feat: offset faces set radius implementation + testing#1769

Merged
jacobrkerstetter merged 6 commits into
mainfrom
feat/offset_faces_set_radius
Feb 25, 2025
Merged

feat: offset faces set radius implementation + testing#1769
jacobrkerstetter merged 6 commits into
mainfrom
feat/offset_faces_set_radius

Conversation

@jacobrkerstetter

@jacobrkerstetter jacobrkerstetter commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

Description

Implemented and tested new geometry command
offset_faces_set_radius changes the radius of a face that represents a hole

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Feb 24, 2025
@jacobrkerstetter
jacobrkerstetter marked this pull request as ready for review February 24, 2025 15:34
@jacobrkerstetter
jacobrkerstetter requested a review from a team as a code owner February 24, 2025 15:34
@github-actions github-actions Bot added the enhancement New features or code improvements label Feb 24, 2025

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobrkerstetter
jacobrkerstetter enabled auto-merge (squash) February 25, 2025 15:25
@codecov

codecov Bot commented Feb 25, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.87%. Comparing base (a838b77) to head (6e59f8b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1769      +/-   ##
==========================================
+ Coverage   90.85%   90.87%   +0.01%     
==========================================
  Files          92       92              
  Lines        8271     8282      +11     
==========================================
+ Hits         7515     7526      +11     
  Misses        756      756              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobrkerstetter
jacobrkerstetter merged commit b753d5e into main Feb 25, 2025
@jacobrkerstetter
jacobrkerstetter deleted the feat/offset_faces_set_radius branch February 25, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants