Skip to content

fix: allow setting max message length for send operations#1775

Merged
RobPasMue merged 2 commits into
mainfrom
fix/grpc-message-length
Feb 25, 2025
Merged

fix: allow setting max message length for send operations#1775
RobPasMue merged 2 commits into
mainfrom
fix/grpc-message-length

Conversation

@RobPasMue
Copy link
Copy Markdown
Member

Description

Issue with max message length. Send operations where not being handled properly.

Issue linked

Partially solves #1765

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Feb 25, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner February 25, 2025 10:26
@github-actions github-actions Bot added the bug Something isn't working label Feb 25, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base (fca7680) to head (6468319).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1775   +/-   ##
=======================================
  Coverage   90.85%   90.85%           
=======================================
  Files          92       92           
  Lines        8271     8271           
=======================================
  Hits         7515     7515           
  Misses        756      756           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit a838b77 into main Feb 25, 2025
@RobPasMue RobPasMue deleted the fix/grpc-message-length branch February 25, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants