feat: Streaming upload support#1779
Conversation
…sys/pyansys-geometry into feat/streaming_upload_support
…sys/pyansys-geometry into feat/streaming_upload_support
… feat/streaming_upload_support
|
The towncrier template has been successfully rewritten with the default template. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## blitz #1779 +/- ##
==========================================
- Coverage 90.51% 90.17% -0.35%
==========================================
Files 92 92
Lines 8727 8801 +74
==========================================
+ Hits 7899 7936 +37
- Misses 828 865 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…o feat/streaming_upload_support
…sys/pyansys-geometry into feat/streaming_upload_support # Conflicts: # src/ansys/geometry/core/designer/body.py
RobPasMue
left a comment
There was a problem hiding this comment.
Looking good @mlkaplan36 - thanks a lot for the changes. One small naming change and a reordering request, and should be good to go
|
@RobPasMue - the failing test in Windows (core-windows-latest, false) passes for me locally, so I'm not sure what the issue could be there. FAILED tests/integration/test_design.py::test_stream_upload_file - grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with: |
|
Let me investigate it next week @mlkaplan36 - if it passes locally for you, it might be a runner (CI/CD) issue |
RobPasMue
left a comment
There was a problem hiding this comment.
Approving - although further streaming testing is definitely needed. Pinging @RyanJWard to see if he can help on that task. We'll merge as is for now.
Description
Client side support for streaming files to/from the server.
Client side support for streaming tessellation from the server.
Issue linked
Closes #1765, #1778
Checklist
feat: extrude circle to cylinder)