feat: imprint curves without a sketch#1781
Merged
Merged
Conversation
Contributor
Author
|
@RobPasMue, please see above and let us know if there is a more preferred way of overloading the method. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1781 +/- ##
==========================================
- Coverage 90.60% 90.58% -0.02%
==========================================
Files 92 92
Lines 8474 8480 +6
==========================================
+ Hits 7678 7682 +4
- Misses 796 798 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rmanno91
previously approved these changes
Feb 26, 2025
RobPasMue
reviewed
Feb 27, 2025
Member
There was a problem hiding this comment.
It's looking good @umutsoysalansys - please handle properly the backwards compatibility inside the method. Once that's done, it's good to go on my side. Request review again once addressed.
rmanno91
approved these changes
Mar 3, 2025
RobPasMue
approved these changes
Mar 10, 2025
RobPasMue
left a comment
Member
There was a problem hiding this comment.
All good - let's merge, thanks @umutsoysalansys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An attempt to overload imprint curves with passing curves directly. See issue linked. Current imprint curves is taking a sketch to get the curves that is needed for backend but apparently that is found limiting for use cases where curves are coming from a set of edges that is not part of the sketch. To serve this need along with other possible usages, we can directly take TrimmedCurve object on client side, and pass it to backend. This PR tries to expose it without breaking the existing use case by overloading it.
Issue linked
#1780
Checklist
feat: extrude circle to cylinder)