Skip to content

feat: separate graphics target#1782

Merged
RobPasMue merged 9 commits into
mainfrom
feat/separate-graphics
Feb 27, 2025
Merged

feat: separate graphics target#1782
RobPasMue merged 9 commits into
mainfrom
feat/separate-graphics

Conversation

@RobPasMue

@RobPasMue RobPasMue commented Feb 26, 2025

Copy link
Copy Markdown
Member

Description

Making graphics an optional target inside PyAnsys Geometry. If users now want graphics features they can install the package as follows:

pip install ansys-geometry-core[graphics]

Issue linked

Closes #1735 #1761

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Feb 26, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner February 26, 2025 15:20
@RobPasMue

Copy link
Copy Markdown
Member Author

Documentation still needed... working on that

@github-actions github-actions Bot added maintenance Package and maintenance related testing Anything related to tests enhancement New features or code improvements labels Feb 26, 2025
@RobPasMue RobPasMue linked an issue Feb 26, 2025 that may be closed by this pull request
@codecov

codecov Bot commented Feb 26, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.54545% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.88%. Comparing base (b753d5e) to head (4141149).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/misc/checks.py 86.36% 3 Missing ⚠️
src/ansys/geometry/core/misc/auxiliary.py 60.00% 2 Missing ⚠️
src/ansys/geometry/core/sketch/face.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1782      +/-   ##
==========================================
+ Coverage   90.87%   90.88%   +0.01%     
==========================================
  Files          92       92              
  Lines        8282     8357      +75     
==========================================
+ Hits         7526     7595      +69     
- Misses        756      762       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue requested a review from PipKat as a code owner February 26, 2025 16:53
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Feb 26, 2025
Comment thread .github/workflows/ci_cd.yml Outdated
@RobPasMue RobPasMue merged commit 8ae7558 into main Feb 27, 2025
@RobPasMue RobPasMue deleted the feat/separate-graphics branch February 27, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visualization capability needs to be an optional feature Simba App build fails on ARM because of VTK dependency

2 participants