feat: RGBA color support#1788
Merged
Merged
Conversation
expanded set body color and set face color tests to include opacity added plotting tests to test plotting with opacity
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1788 +/- ##
=======================================
Coverage 90.90% 90.91%
=======================================
Files 92 92
Lines 8422 8471 +49
=======================================
+ Hits 7656 7701 +45
- Misses 766 770 +4 ☔ View full report in Codecov by Sentry. |
RobPasMue
reviewed
Feb 28, 2025
…yansys-geometry into feat/rgba_colors_support
RobPasMue
reviewed
Mar 3, 2025
Member
RobPasMue
left a comment
There was a problem hiding this comment.
One small extra comment - apart from that all good. Also, CI/CD seems to have some issues. Have you seen them? Once comment is implemented and CI/CD issues are solved I will approve the PR
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
RobPasMue
previously approved these changes
Mar 4, 2025
RobPasMue
previously approved these changes
Mar 4, 2025
RobPasMue
previously approved these changes
Mar 4, 2025
RobPasMue
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue linked
Checklist
feat: extrude circle to cylinder)