Skip to content

feat: RGBA color support#1788

Merged
jacobrkerstetter merged 17 commits into
mainfrom
feat/rgba_colors_support
Mar 4, 2025
Merged

feat: RGBA color support#1788
jacobrkerstetter merged 17 commits into
mainfrom
feat/rgba_colors_support

Conversation

@jacobrkerstetter
Copy link
Copy Markdown
Contributor

@jacobrkerstetter jacobrkerstetter commented Feb 28, 2025

Description

  • added keep_alpha flag to mcolors.to_hex calls
  • expanded set body color and set face color tests to include opacity added plotting tests to test plotting with opacity

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

expanded set body color and set face color tests to include opacity
added plotting tests to test plotting with opacity
@jacobrkerstetter jacobrkerstetter self-assigned this Feb 28, 2025
@jacobrkerstetter jacobrkerstetter changed the title RGBA Color Support feat: RGBA color support Feb 28, 2025
@github-actions github-actions Bot added the enhancement New features or code improvements label Feb 28, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 91.52542% with 5 lines in your changes missing coverage. Please review.

Project coverage is 90.91%. Comparing base (b6b5eda) to head (5d23e4e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/body.py 88.46% 3 Missing ⚠️
src/ansys/geometry/core/plotting/plotter.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1788   +/-   ##
=======================================
  Coverage   90.90%   90.91%           
=======================================
  Files          92       92           
  Lines        8422     8471   +49     
=======================================
+ Hits         7656     7701   +45     
- Misses        766      770    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/ansys/geometry/core/designer/body.py Outdated
Comment thread src/ansys/geometry/core/designer/face.py Outdated
@jacobrkerstetter jacobrkerstetter marked this pull request as ready for review February 28, 2025 16:19
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner February 28, 2025 16:19
@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) March 3, 2025 14:58
Copy link
Copy Markdown
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small extra comment - apart from that all good. Also, CI/CD seems to have some issues. Have you seen them? Once comment is implemented and CI/CD issues are solved I will approve the PR

Comment thread src/ansys/geometry/core/designer/body.py
RobPasMue
RobPasMue previously approved these changes Mar 4, 2025
RobPasMue
RobPasMue previously approved these changes Mar 4, 2025
RobPasMue
RobPasMue previously approved these changes Mar 4, 2025
@github-actions github-actions Bot added the maintenance Package and maintenance related label Mar 4, 2025
@jacobrkerstetter jacobrkerstetter merged commit 8de6575 into main Mar 4, 2025
@jacobrkerstetter jacobrkerstetter deleted the feat/rgba_colors_support branch March 4, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants