feat: enhanced 3D bounding box implementation#1805
Merged
Conversation
deprecated BoundingBox2D
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1805 +/- ##
==========================================
+ Coverage 90.58% 90.64% +0.05%
==========================================
Files 92 92
Lines 8480 8559 +79
==========================================
+ Hits 7682 7758 +76
- Misses 798 801 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
requested changes
Mar 10, 2025
RobPasMue
left a comment
Member
There was a problem hiding this comment.
Looking good - just left a few comments =) re-request review once addressed
… feat/enhanced_bounding_boxes
…ys/pyansys-geometry into feat/enhanced_bounding_boxes # Conflicts: # src/ansys/geometry/core/math/bbox.py
…ys/pyansys-geometry into feat/enhanced_bounding_boxes
RobPasMue
reviewed
Mar 10, 2025
RobPasMue
reviewed
Mar 10, 2025
RobPasMue
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue linked
Checklist
feat: extrude circle to cylinder)