Conversation
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Contributor
|
@jacobrkerstetter should this call |
RobPasMue
requested changes
Mar 12, 2025
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (88.75%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## blitz #1820 +/- ##
==========================================
+ Coverage 88.74% 88.75% +0.01%
==========================================
Files 92 92
Lines 8593 8603 +10
==========================================
+ Hits 7626 7636 +10
Misses 967 967 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
reviewed
Mar 12, 2025
Member
RobPasMue
left a comment
There was a problem hiding this comment.
One minor comment - thanks @jacobrkerstetter!
Member
|
You might need to bump the API package version too, right? 0.4.47 if I am not mistaken |
adding docstring
…yansys-geometry into feat/object_name_setters
RobPasMue
reviewed
Mar 12, 2025
RobPasMue
approved these changes
Mar 12, 2025
RobPasMue
reviewed
Mar 12, 2025
RobPasMue
reviewed
Mar 12, 2025
RobPasMue
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue linked
Checklist
feat: extrude circle to cylinder)