fix: change Core Service path to executable/DLL after renaming - #1841
Merged
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
2 tasks
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (88.55%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1841 +/- ##
==========================================
- Coverage 88.72% 88.55% -0.17%
==========================================
Files 92 92
Lines 8559 8575 +16
==========================================
Hits 7594 7594
- Misses 965 981 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
commented
Mar 19, 2025
RobPasMue
force-pushed
the
fix/core-service-change
branch
from
March 19, 2025 07:57
b3653de to
70b15c0
Compare
RobPasMue
force-pushed
the
fix/core-service-change
branch
from
March 19, 2025 07:57
70b15c0 to
dd0bfdc
Compare
b-matteo
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Service rename happened before release - no breaking change consequently to previous Ansys releases. Also, DMS will be retired starting on 25R2 and thus it is necessary to handle the fallback to Core Service in case version is 25R2 or above.
Issue linked
Closes #1818
Checklist
feat: extrude circle to cylinder)