feat: blitz (2nd round) by RobPasMue · Pull Request #1853 · ansys/pyansys-geometry

RobPasMue · 2025-03-20T09:58:12Z

Description

Pull request merging all the developments performed during the second blitz of the year. Full review of all addressed changes required.

Tasks

Revert CI/CD file changes - the original one should prevail
Verify proper usage of version decorators and backwards-compatible changes
Ensure proper testing is in place for all API
Ensure docstrings are properly documented
Submit cleanup PR (PENDING)

Issue linked

None

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Umut Soysal <97195410+umutsoysalansys@users.noreply.github.com> Co-authored-by: Jacob Kerstetter <jacob.kerstetter@ansys.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Umut Soysal <97195410+umutsoysalansys@users.noreply.github.com>

Co-authored-by: Jacob Kerstetter <jacob.kerstetter@ansys.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Co-authored-by: Umut Soysal <97195410+umutsoysalansys@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Co-authored-by: Umut Soysal <97195410+umutsoysalansys@users.noreply.github.com>

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Jacob Kerstetter <jacob.kerstetter@ansys.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…#1850) Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

Co-authored-by: PyAnsys CI Bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

codecov · 2025-03-20T10:13:30Z

Codecov Report

Attention: Patch coverage is 77.18750% with 73 lines in your changes missing coverage. Please review.

Project coverage is 89.96%. Comparing base (8bb7af7) to head (d874b97).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/ansys/geometry/core/designer/body.py	30.00%	21 Missing ⚠️
src/ansys/geometry/core/designer/beam.py	81.25%	18 Missing ⚠️
src/ansys/geometry/core/misc/options.py	60.00%	10 Missing ⚠️
src/ansys/geometry/core/modeler.py	73.33%	8 Missing ⚠️
src/ansys/geometry/core/designer/design.py	71.42%	6 Missing ⚠️
src/ansys/geometry/core/tools/prepare_tools.py	78.57%	3 Missing ⚠️
src/ansys/geometry/core/designer/face.py	60.00%	2 Missing ⚠️
src/ansys/geometry/core/connection/launcher.py	50.00%	1 Missing ⚠️
src/ansys/geometry/core/designer/component.py	97.22%	1 Missing ⚠️
src/ansys/geometry/core/math/matrix.py	94.73%	1 Missing ⚠️
... and 2 more

❌ Your project status has failed because the head coverage (89.96%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1853      +/-   ##
==========================================
+ Coverage   88.55%   89.96%   +1.40%     
==========================================
  Files          92       92              
  Lines        8575     8847     +272     
==========================================
+ Hits         7594     7959     +365     
+ Misses        981      888      -93

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Jacob Kerstetter <jacob.kerstetter@ansys.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

RobPasMue

Review on my side... opening a PR to fix the identified issues

RobPasMue · 2025-03-20T16:46:21Z

Waiting for reviews on @jonahrb and @b-matteo before opening another PR that would fix the various issues identified.

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

RobPasMue and others added 14 commits March 12, 2025 14:18

ci: simplify blitz ci

e07aeb3

fix: translating sketch issues when using a custom default unit (#1808)

4e2eeb3

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

feat: matrix helper methods (#1806)

22bb08f

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>

fix: edge start and end were not being mapped correctly (#1816)

5515312

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

ci: use proper runner

ce21ad6

build: ansys api geometry 0.4.49 (#1840)

3835d66

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

fix: tessellation options were not extended to component/face methods (…

371d89a

…#1850) Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

feat: Remove rounds (#1851)

d902047

Co-authored-by: PyAnsys CI Bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

RobPasMue self-assigned this Mar 20, 2025

RobPasMue added 2 commits March 20, 2025 11:35

Merge branch 'main' into blitz

2a7dce3

fix: revert changes from main

4c6a182

github-actions Bot added the testing Anything related to tests label Mar 20, 2025

fix: revert named selection file

23766c2

RobPasMue force-pushed the blitz branch from c0f783d to 23766c2 Compare March 20, 2025 13:29

fix: use the NamedSelectionImport.scdocx in main

675d74f

RobPasMue force-pushed the blitz branch from 9bb5f15 to 675d74f Compare March 20, 2025 13:42

pyansys-ci-bot and others added 2 commits March 20, 2025 13:45

chore: adding changelog file 1853.added.md [dependabot-skip]

d801c35

fix: named selection import test (#1854)

88fb082

Co-authored-by: Jacob Kerstetter <jacob.kerstetter@ansys.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

RobPasMue added the enhancement New features or code improvements label Mar 20, 2025

RobPasMue commented Mar 20, 2025

View reviewed changes

b-matteo previously approved these changes Mar 21, 2025

View reviewed changes

RobPasMue mentioned this pull request Mar 21, 2025

chore: cleanup blitz PR #1855

Merged

9 tasks

chore: cleanup blitz PR (#1855)

d874b97

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>

RobPasMue dismissed b-matteo’s stale review via d874b97 March 21, 2025 10:58

RobPasMue marked this pull request as ready for review March 21, 2025 10:58

RobPasMue requested a review from a team as a code owner March 21, 2025 10:58

RobPasMue enabled auto-merge (squash) March 21, 2025 10:58

RobPasMue disabled auto-merge March 21, 2025 11:52

RobPasMue merged commit bd3b65d into main Mar 21, 2025

RobPasMue deleted the blitz branch March 21, 2025 11:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: blitz (2nd round)#1853

feat: blitz (2nd round)#1853
RobPasMue merged 21 commits into
mainfrom
blitz

RobPasMue commented Mar 20, 2025 •

edited

Loading

Uh oh!

codecov Bot commented Mar 20, 2025 •

edited

Loading

Uh oh!

RobPasMue left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RobPasMue commented Mar 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

RobPasMue commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Tasks

Issue linked

Uh oh!

codecov Bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

RobPasMue left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RobPasMue commented Mar 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

RobPasMue commented Mar 20, 2025 •

edited

Loading

codecov Bot commented Mar 20, 2025 •

edited

Loading