Skip to content

fix: named selection import test#1854

Merged
RobPasMue merged 3 commits into
blitzfrom
fix/named_selection_imports
Mar 20, 2025
Merged

fix: named selection import test#1854
RobPasMue merged 3 commits into
blitzfrom
fix/named_selection_imports

Conversation

@jacobrkerstetter

Copy link
Copy Markdown
Contributor

Description

  • added new model for import test
  • revised changes that were causing conflicts

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

fixed test to reflect new model
@jacobrkerstetter jacobrkerstetter self-assigned this Mar 20, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner March 20, 2025 15:06
@github-actions github-actions Bot added the bug Something isn't working label Mar 20, 2025

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue enabled auto-merge (squash) March 20, 2025 15:13
@codecov

codecov Bot commented Mar 20, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.95%. Comparing base (d3fcc9d) to head (249c87e).
Report is 20 commits behind head on blitz.

❌ Your project status has failed because the head coverage (89.95%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##            blitz    #1854      +/-   ##
==========================================
- Coverage   90.18%   89.95%   -0.23%     
==========================================
  Files          92       92              
  Lines        8801     8839      +38     
==========================================
+ Hits         7937     7951      +14     
- Misses        864      888      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue merged commit 88fb082 into blitz Mar 20, 2025
@RobPasMue RobPasMue deleted the fix/named_selection_imports branch March 20, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants