feat: repair tools refactoring#1912
Conversation
…om/ansys/pyansys-geometry into feat/grpc-common-layer-refactoring
…om/ansys/pyansys-geometry into feat/grpc-common-layer-refactoring
…om/ansys/pyansys-geometry into feat/grpc-common-layer-refactoring
…om/ansys/pyansys-geometry into feat/grpc-common-layer-refactoring
There was a problem hiding this comment.
Looking great @umutsoysalansys - just left a few comments. The main one is related to the "DoubleValue". The rest are mostly formatting and docstring suggestions which you can just add and commit =) thanks a lot!! Once comments are resolved, I will approve again and merge.
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
|
@RobPasMue what is the doc error, can we make these things more descriptive? Which py file lines are corresponding to the rst file lines? I can't see |
I wish we could -- that's just Sphinx and other tools complaining... Nonetheless, the problem is still the docstring I referred to in this comment #1912 (comment) I would remove the docstring if possible -- the other option is to format it properly based on the comments you are getting, but I know it is a painful process because you have a non-standard docstring |
Description
Refactoring repair tools to move repair stubs to the central area. See the issue for more details.
Issue linked
#1817
Checklist
feat: extrude circle to cylinder)