Skip to content

feat: grpc driving dimensions stub implementation - #1921

Merged
jacobrkerstetter merged 13 commits into
mainfrom
feat/driving_dimensions_stub_relocation
Apr 23, 2025
Merged

feat: grpc driving dimensions stub implementation#1921
jacobrkerstetter merged 13 commits into
mainfrom
feat/driving_dimensions_stub_relocation

Conversation

@jacobrkerstetter

@jacobrkerstetter jacobrkerstetter commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

Description

  • moved driving dimensions stub to new location
  • adjusted usages to use new stub

Issue linked

#1817

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Apr 17, 2025
@jacobrkerstetter
jacobrkerstetter requested a review from a team as a code owner April 17, 2025 18:05
@github-actions github-actions Bot added the enhancement New features or code improvements label Apr 17, 2025
@codecov

codecov Bot commented Apr 17, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 90.14085% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.36%. Comparing base (e54ba43) to head (298859c).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...etry/core/_grpc/_services/v1/driving_dimensions.py 71.42% 4 Missing ⚠️
...ansys/geometry/core/connection/product_instance.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1921      +/-   ##
==========================================
- Coverage   90.39%   90.36%   -0.03%     
==========================================
  Files         114      117       +3     
  Lines        9545     9593      +48     
==========================================
+ Hits         8628     8669      +41     
- Misses        917      924       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/ansys/geometry/core/_grpc/_services/_service.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v0/conversions.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v0/driving_dimensions.py Outdated
@RobPasMue

Copy link
Copy Markdown
Member

Blocked by #1924

@RobPasMue RobPasMue mentioned this pull request Apr 23, 2025
9 tasks
Comment thread src/ansys/geometry/core/_grpc/_services/v0/conversions.py
Comment thread src/ansys/geometry/core/_grpc/_services/v0/conversions.py
@jacobrkerstetter
jacobrkerstetter enabled auto-merge (squash) April 23, 2025 15:31

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging!

@jacobrkerstetter
jacobrkerstetter merged commit bd47714 into main Apr 23, 2025
@jacobrkerstetter
jacobrkerstetter deleted the feat/driving_dimensions_stub_relocation branch April 23, 2025 15:49
@RobPasMue RobPasMue linked an issue Apr 30, 2025 that may be closed by this pull request
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle gRPC API calls from central location

3 participants