Repository navigation
feat: Find and Fix Stitch/Missing/Small Faces Enhancements - #1953
Merged
Merged
Conversation
added find_and_fix_stitch_faces added applicable tests (comprehensive and standard)
This was
linked to
issues
May 1, 2025
Closed
switching default value on find and fix to None
…ub.com/ansys/pyansys-geometry into feat/find_fix_stitch_faces_enhancement
jacobrkerstetter
marked this pull request as draft
May 1, 2025 17:47
jacobrkerstetter
changed the title
jacobrkerstetter
marked this pull request as ready for review
May 6, 2025 20:14
Member
|
Hi @jacobrkerstetter! Let's wait for #1912 to be merged and then you can adapt your implementation to the new structure. Sounds good? |
… feat/find_fix_stitch_faces_enhancement
… feat/find_fix_stitch_faces_enhancement # Conflicts: # src/ansys/geometry/core/tools/repair_tools.py
Member
What's the status here @jacobrkerstetter - I see all tests are passing now. Are we still looking at bugs on SC side? |
jacobrkerstetter
changed the title
…ub.com/ansys/pyansys-geometry into feat/find_fix_stitch_faces_enhancement
used this in small faces extra parameters
…ub.com/ansys/pyansys-geometry into feat/find_fix_stitch_faces_enhancement
…ub.com/ansys/pyansys-geometry into feat/find_fix_stitch_faces_enhancement
jacobrkerstetter
marked this pull request as ready for review
June 16, 2025 14:04
RyanJWard
previously approved these changes
Jun 16, 2025
RyanJWard
left a comment
RyanJWard
left a comment
Contributor
There was a problem hiding this comment.
I tested these changes and expanded the test coverage
RobPasMue
reviewed
Jun 16, 2025
RobPasMue
left a comment
RobPasMue
left a comment
Member
There was a problem hiding this comment.
Left a few version-handling comments. Apart from that... this looks awesome! Thanks @RyanJWard and @jacobrkerstetter for the hard work here!
added version checking for new options add logger warning for when the backend is older but the user supplies options
RyanJWard
approved these changes
Jun 16, 2025
RobPasMue
approved these changes
Jun 16, 2025
RobPasMue
left a comment
RobPasMue
left a comment
Member
There was a problem hiding this comment.
Awesome, LGTM! Thanks a lot @jacobrkerstetter and @RyanJWard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
added model for testing stitching many faces
added find_and_fix_stitch_faces
added applicable tests (comprehensive and standard)
Issue linked
#1947
#1949
#1950
Checklist
feat: extrude circle to cylinder)