feat: NURBS and TrimmedCurve enhancements - #1994
Merged
Merged
Conversation
… feat/nurbs_enhancements
… feat/nurbs_enhancements
jacobrkerstetter
changed the title
github-actions
Bot
added
testing
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1994 +/- ##
==========================================
- Coverage 90.45% 90.45% -0.01%
==========================================
Files 136 136
Lines 9730 9782 +52
==========================================
+ Hits 8801 8848 +47
- Misses 929 934 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
requested changes
May 21, 2025
…ansys-geometry into feat/nurbs_enhancements # Conflicts: # src/ansys/geometry/core/shapes/curves/curve_evaluation.py # src/ansys/geometry/core/shapes/curves/trimmed_curve.py
RobPasMue
requested changes
May 21, 2025
RobPasMue
left a comment
RobPasMue
left a comment
Member
There was a problem hiding this comment.
We are missing a lot of testing on the new methods in trimmed curves. Can we add them?
…d_copy added tests for line and circle trimmed curve translation and rotation
…ansys-geometry into feat/nurbs_enhancements
RobPasMue
reviewed
May 26, 2025
… feat/nurbs_enhancements
change vector transform append from 1 to 0
…ansys-geometry into feat/nurbs_enhancements
…ansys-geometry into feat/nurbs_enhancements
putting back removed lines in test_primitives
RobPasMue
reviewed
Jun 9, 2025
RobPasMue
previously approved these changes
Jun 9, 2025
RobPasMue
left a comment
RobPasMue
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks @jacobrkerstetter - just left a small comment!
RobPasMue
reviewed
Jun 9, 2025
RobPasMue
approved these changes
Jun 9, 2025
RobPasMue
enabled auto-merge (squash)
June 9, 2025 07:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue linked
Checklist
feat: extrude circle to cylinder)