Skip to content

feat: deprecating product_version in favor of version - #1998

Merged
RobPasMue merged 5 commits into
mainfrom
feat/deprecate-product-version
May 26, 2025
Merged

RobPasMue merged 5 commits into
mainfrom
feat/deprecate-product-version

Conversation

@RobPasMue

Copy link
Copy Markdown
Member

Description

Coming from user request to enhance UX. We should deprecate the "product_version" input and just simplify it to "version". Also, str and int should be allowed as input.

@RobPasMue RobPasMue self-assigned this May 26, 2025
@RobPasMue
RobPasMue requested a review from a team as a code owner May 26, 2025 13:09
@github-actions github-actions Bot added the enhancement New features or code improvements label May 26, 2025
@RobPasMue
RobPasMue merged commit 8d0a7df into main May 26, 2025
@RobPasMue
RobPasMue deleted the feat/deprecate-product-version branch May 26, 2025 16:31
@codecov

codecov Bot commented May 26, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 45.45455% with 24 lines in your changes missing coverage. Please review.

Project coverage is 90.40%. Comparing base (db1753f) to head (72170b0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ansys/geometry/core/connection/product_instance.py 16.00% 21 Missing ⚠️
src/ansys/geometry/core/connection/launcher.py 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1998      +/-   ##
==========================================
- Coverage   90.46%   90.40%   -0.06%     
==========================================
  Files         136      136              
  Lines        9717     9730      +13     
==========================================
+ Hits         8790     8796       +6     
- Misses        927      934       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants