Skip to content

fix: typo in the open request construction - #2022

Merged
RobPasMue merged 2 commits into
mainfrom
fix/wrong_request_fieldname_for_openrequest
Jun 5, 2025
Merged

RobPasMue merged 2 commits into
mainfrom
fix/wrong_request_fieldname_for_openrequest

Conversation

@b-matteo

@b-matteo b-matteo commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

Description

Open request was failing due to a typo into the OpenRequest object construction

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@b-matteo
b-matteo requested a review from RobPasMue June 5, 2025 12:15
@b-matteo b-matteo self-assigned this Jun 5, 2025
@b-matteo
b-matteo requested a review from a team as a code owner June 5, 2025 12:15
@b-matteo b-matteo added the bug Something isn't working label Jun 5, 2025
RobPasMue
RobPasMue previously approved these changes Jun 5, 2025
@RobPasMue RobPasMue changed the title bug: fix typo into the open request construction fix: typo in the open request construction Jun 5, 2025
@RobPasMue
RobPasMue enabled auto-merge (squash) June 5, 2025 12:25
@codecov

codecov Bot commented Jun 5, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.45%. Comparing base (47e486f) to head (6fcecf8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2022   +/-   ##
=======================================
  Coverage   90.45%   90.45%           
=======================================
  Files         136      136           
  Lines        9730     9730           
=======================================
  Hits         8801     8801           
  Misses        929      929           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue
RobPasMue merged commit e13d3aa into main Jun 5, 2025
@RobPasMue
RobPasMue deleted the fix/wrong_request_fieldname_for_openrequest branch June 5, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants