Skip to content

test: expanding test coverage for sketch - #2047

Merged
syscordan merged 15 commits into
mainfrom
test/syscordan_sketch_coverage
Jun 18, 2025
Merged

syscordan merged 15 commits into
mainfrom
test/syscordan_sketch_coverage

Conversation

@syscordan

Copy link
Copy Markdown
Contributor

Description

Expand test coverage for sketch\edge.py
sketch\face.py
sketch\ellipse.py - note issue asking Jonah
sketch\gears.py
sketch\segment.py
sketch\circle.py
sketch\sketch.py

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@syscordan syscordan self-assigned this Jun 17, 2025
@syscordan
syscordan requested a review from a team as a code owner June 17, 2025 17:10
@RyanJWard RyanJWard changed the title expanding test coverage for sketch test: expanding test coverage for sketch Jun 17, 2025
@github-actions github-actions Bot added the testing Anything related to tests label Jun 17, 2025
@codecov

codecov Bot commented Jun 17, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@4a3dda3). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2047   +/-   ##
=======================================
  Coverage        ?   92.30%           
=======================================
  Files           ?      136           
  Lines           ?     9811           
  Branches        ?        0           
=======================================
  Hits            ?     9056           
  Misses          ?      755           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

syscordan and others added 3 commits June 17, 2025 11:34
Revert "fix pre-commit"

This reverts commit da353fb.
Comment thread tests/test_sketch.py
Comment thread tests/test_sketch.py
Comment thread tests/test_sketch.py Outdated
Comment thread tests/test_sketch.py Outdated
@syscordan
syscordan merged commit ba21a38 into main Jun 18, 2025
@syscordan
syscordan deleted the test/syscordan_sketch_coverage branch June 18, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants