feat: allow logos Linux 26 1#2048
Merged
Merged
Conversation
github-actions
Bot
added
testing
…s/pyansys-geometry into feat/allow_logos_linux_26_1
RobPasMue
reviewed
Jun 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2048 +/- ##
==========================================
- Coverage 92.72% 92.29% -0.43%
==========================================
Files 137 137
Lines 9909 9909
==========================================
- Hits 9188 9146 -42
- Misses 721 763 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonahrb
approved these changes
Jul 2, 2025
RobPasMue
reviewed
Jul 7, 2025
Comment on lines
+139
to
143
| # Skip the rest of the test if running on a Linux service backend | ||
| if BackendType.is_linux_service(modeler.client.backend_type): | ||
| return | ||
| assert success is True | ||
| assert len(body.faces) == 42 |
Member
There was a problem hiding this comment.
Why had the rest to be skipped?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the latest 26.1 Linux service prepare logo tools should be fixed
Checklist
feat: extrude circle to cylinder)