feat: add components to NS - #2068
Merged
Merged
Conversation
tested with a box
jacobrkerstetter
marked this pull request as draft
June 25, 2025 13:30
Member
|
This might need some server side fix. Which means that we should also warn that components can only be translated starting on 26R1 I guess - unless we plan on adding this feature to a SP for 25R2. |
reverted changes to move_translate
…nsys/pyansys-geometry into feat/move_translate_components
jacobrkerstetter
marked this pull request as ready for review
June 25, 2025 13:55
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2068 +/- ##
==========================================
- Coverage 92.86% 92.83% -0.03%
==========================================
Files 137 137
Lines 9877 9894 +17
==========================================
+ Hits 9172 9185 +13
- Misses 705 709 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacobrkerstetter
marked this pull request as draft
June 25, 2025 14:52
added a test to fetch components from NS
…nsys/pyansys-geometry into feat/move_translate_components
jacobrkerstetter
marked this pull request as ready for review
July 1, 2025 10:18
…nsys/pyansys-geometry into feat/move_translate_components
jonahrb
approved these changes
Jul 2, 2025
jonahrb
left a comment
Contributor
There was a problem hiding this comment.
LGTM - re approving for Roberto
RobPasMue
reviewed
Jul 7, 2025
RobPasMue
left a comment
Member
There was a problem hiding this comment.
Thank you @jonahrb and @jacobrkerstetter for approving and implementing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue linked
#2067
Checklist
feat: extrude circle to cylinder)