Skip to content

feat: add mating conditions (align, tangent, orient)#2069

Merged
jonahrb merged 12 commits into
mainfrom
feat/mating-conditions
Jul 2, 2025
Merged

feat: add mating conditions (align, tangent, orient)#2069
jonahrb merged 12 commits into
mainfrom
feat/mating-conditions

Conversation

@jonahrb

@jonahrb jonahrb commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

Description

Create mating conditions that persist and constrain geometry.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb jonahrb requested a review from a team as a code owner June 25, 2025 14:28
@jonahrb jonahrb self-assigned this Jun 25, 2025
@github-actions github-actions Bot added the enhancement New features or code improvements label Jun 25, 2025

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments - thanks for the PR @jonahrb!

Comment thread src/ansys/geometry/core/designer/body.py
Comment thread src/ansys/geometry/core/designer/geometry_commands.py
Comment thread src/ansys/geometry/core/designer/geometry_commands.py
Comment thread src/ansys/geometry/core/designer/mating_conditions.py Outdated
RobPasMue
RobPasMue previously approved these changes Jun 26, 2025

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonahrb jonahrb requested a review from RobPasMue June 30, 2025 17:52
@github-actions github-actions Bot added the maintenance Package and maintenance related label Jun 30, 2025
@codecov

codecov Bot commented Jul 1, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.86%. Comparing base (1e12262) to head (829b739).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2069      +/-   ##
==========================================
+ Coverage   92.84%   92.86%   +0.01%     
==========================================
  Files         136      137       +1     
  Lines        9813     9877      +64     
==========================================
+ Hits         9111     9172      +61     
- Misses        702      705       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot removed the maintenance Package and maintenance related label Jul 2, 2025
@jonahrb jonahrb enabled auto-merge (squash) July 2, 2025 13:22
@b-matteo b-matteo self-requested a review July 2, 2025 13:28

@b-matteo b-matteo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jonahrb, @RobPasMue re enabling approval here.

@jonahrb jonahrb merged commit 72c56fa into main Jul 2, 2025
44 checks passed
@jonahrb jonahrb deleted the feat/mating-conditions branch July 2, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants