feat: vertex references - #2083
Merged
Merged
Conversation
simple test in place - wip
finished test to test locations
tested with a box
reverted changes to move_translate
…nsys/pyansys-geometry into feat/move_translate_components
added a test to fetch components from NS
…nsys/pyansys-geometry into feat/move_translate_components
… feat/edges_get_vertices
…nsys/pyansys-geometry into feat/edges_get_vertices
…nsys/pyansys-geometry into feat/edges_get_vertices
added vertices client side support on body + tested
added test for NS with vertices
tested importing NS with vertices
… feat/edges_get_vertices # Conflicts: # src/ansys/geometry/core/_grpc/_services/v0/named_selection.py # src/ansys/geometry/core/designer/design.py # src/ansys/geometry/core/designer/geometry_commands.py # src/ansys/geometry/core/designer/selection.py
…ansys-geometry into feat/edges_get_vertices
jacobrkerstetter
marked this pull request as ready for review
July 2, 2025 17:03
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2083 +/- ##
=======================================
Coverage ? 92.85%
=======================================
Files ? 138
Lines ? 9990
Branches ? 0
=======================================
Hits ? 9276
Misses ? 714
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
requested changes
Jul 7, 2025
RobPasMue
left a comment
RobPasMue
left a comment
Member
There was a problem hiding this comment.
Left a few comments - but overall it's looking good, thanks @jacobrkerstetter!
min backend decorators added
…ansys-geometry into feat/edges_get_vertices
RobPasMue
reviewed
Jul 7, 2025
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
RobPasMue
approved these changes
Jul 7, 2025
RobPasMue
left a comment
RobPasMue
left a comment
Member
There was a problem hiding this comment.
LGTM! Awesome implementation @jacobrkerstetter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue linked
Checklist
feat: extrude circle to cylinder)