feat: nurbs sketching and surface support - #2104
Merged
Merged
Conversation
added contains_point for 2d nurbs
… feat/nurbs_sketching
copy conversions from new services dir to old one add test for fill nurbs sketch
… feat/nurbs_sketching
github-actions
Bot
added
testing
…ys-geometry into feat/nurbs_sketching # Conflicts: # src/ansys/geometry/core/designer/geometry_commands.py
…ys-geometry into feat/nurbs_sketching
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2104 +/- ##
==========================================
- Coverage 94.21% 94.19% -0.02%
==========================================
Files 138 139 +1
Lines 10156 10242 +86
==========================================
+ Hits 9568 9647 +79
- Misses 588 595 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
reviewed
Jul 16, 2025
RobPasMue
left a comment
RobPasMue
left a comment
Member
There was a problem hiding this comment.
Left a few comments - overall is looking good!
…ys-geometry into feat/nurbs_sketching
…ys-geometry into feat/nurbs_sketching
jacobrkerstetter
enabled auto-merge (squash)
July 16, 2025 14:00
RobPasMue
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide ability to sketch 2D NURBS curves and transform them into surface bodies for Workflow 12.
Issue linked
Checklist
feat: extrude circle to cylinder)