Skip to content

fix: workflow 2b nurbs fixes#2137

Merged
jacobrkerstetter merged 9 commits into
mainfrom
fix/workflow_2b_fixes
Jul 29, 2025
Merged

fix: workflow 2b nurbs fixes#2137
jacobrkerstetter merged 9 commits into
mainfrom
fix/workflow_2b_fixes

Conversation

@jacobrkerstetter

@jacobrkerstetter jacobrkerstetter commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

Description

changes approximate_curve to interpolate_curve
added copy constructor ability to NURBSCurve class
added length property

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Jul 28, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner July 28, 2025 18:27
@github-actions github-actions Bot added the bug Something isn't working label Jul 28, 2025
@codecov

codecov Bot commented Jul 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.77%. Comparing base (80861a5) to head (ef8cc31).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/shapes/curves/nurbs.py 26.66% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2137      +/-   ##
==========================================
- Coverage   94.87%   94.77%   -0.11%     
==========================================
  Files         141      141              
  Lines       10294    10307      +13     
==========================================
+ Hits         9766     9768       +2     
- Misses        528      539      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/ansys/geometry/core/shapes/curves/nurbs.py Outdated
Comment thread src/ansys/geometry/core/shapes/curves/nurbs.py Outdated
Comment thread src/ansys/geometry/core/shapes/curves/nurbs.py Outdated
Comment thread src/ansys/geometry/core/shapes/curves/nurbs.py Outdated
jonahrb
jonahrb previously approved these changes Jul 29, 2025
@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) July 29, 2025 17:18
@jacobrkerstetter jacobrkerstetter merged commit 603bb1a into main Jul 29, 2025
51 checks passed
@jacobrkerstetter jacobrkerstetter deleted the fix/workflow_2b_fixes branch July 29, 2025 18:31
@RobPasMue

Copy link
Copy Markdown
Member

@jacobrkerstetter @jonahrb please add tests for the newly inserted code... We should not merge PRs where the code is not being tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants