Skip to content

fix: make import component named selections optional - #2144

Merged
jonahrb merged 15 commits into
mainfrom
fix/optional-import-component-groups
Aug 15, 2025
Merged

fix: make import component named selections optional#2144
jonahrb merged 15 commits into
mainfrom
fix/optional-import-component-groups

Conversation

@jonahrb

@jonahrb jonahrb commented Jul 30, 2025

Copy link
Copy Markdown
Contributor

Description

When inserting a file, now specify if you want named selection to be imported, defaults True.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb
jonahrb requested a review from a team as a code owner July 30, 2025 18:11
@jonahrb jonahrb self-assigned this Jul 30, 2025
@github-actions github-actions Bot added the bug Something isn't working label Jul 30, 2025
@github-actions github-actions Bot added the testing Anything related to tests label Jul 31, 2025
@codecov

codecov Bot commented Aug 4, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.70%. Comparing base (d3179d8) to head (2dcbbac).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/component.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2144      +/-   ##
==========================================
- Coverage   94.71%   94.70%   -0.01%     
==========================================
  Files         141      141              
  Lines       10323    10327       +4     
==========================================
+ Hits         9777     9780       +3     
- Misses        546      547       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread tests/integration/test_design_import.py
@github-actions github-actions Bot added the maintenance Package and maintenance related label Aug 12, 2025
@github-actions github-actions Bot removed the maintenance Package and maintenance related label Aug 14, 2025
RobPasMue
RobPasMue previously approved these changes Aug 14, 2025

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonahrb
jonahrb requested a review from RobPasMue August 14, 2025 16:47
@jonahrb
jonahrb enabled auto-merge (squash) August 14, 2025 16:47

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahrb
jonahrb merged commit 0b49f0f into main Aug 15, 2025
51 checks passed
@jonahrb
jonahrb deleted the fix/optional-import-component-groups branch August 15, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants