Skip to content

feat: remove materials - #2180

Merged
RobPasMue merged 9 commits into
mainfrom
feat/remove_materials
Aug 20, 2025
Merged

feat: remove materials#2180
RobPasMue merged 9 commits into
mainfrom
feat/remove_materials

Conversation

@jacobrkerstetter

Copy link
Copy Markdown
Contributor

Description

  • added ability to remove materials from document and specific bodies by request of FluidsOne team

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions Bot added the enhancement New features or code improvements label Aug 18, 2025
@jacobrkerstetter
jacobrkerstetter marked this pull request as ready for review August 19, 2025 13:08
@jacobrkerstetter
jacobrkerstetter requested a review from a team as a code owner August 19, 2025 13:08
Comment thread tests/integration/test_design.py
Comment thread src/ansys/geometry/core/designer/body.py
Comment thread src/ansys/geometry/core/designer/design.py
@codecov

codecov Bot commented Aug 19, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.63%. Comparing base (32797ba) to head (2bc4876).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/body.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2180   +/-   ##
=======================================
  Coverage   94.62%   94.63%           
=======================================
  Files         141      141           
  Lines       10361    10392   +31     
=======================================
+ Hits         9804     9834   +30     
- Misses        557      558    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue
RobPasMue enabled auto-merge (squash) August 20, 2025 16:22
@RobPasMue
RobPasMue merged commit 46477e2 into main Aug 20, 2025
122 of 131 checks passed
@RobPasMue
RobPasMue deleted the feat/remove_materials branch August 20, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants