Skip to content

feat: move geometry commands to versioned architecture - #2234

Merged
RobPasMue merged 26 commits into
mainfrom
feat/geometry_commands_restructure
Sep 25, 2025
Merged

RobPasMue merged 26 commits into
mainfrom
feat/geometry_commands_restructure

Conversation

@jacobrkerstetter

Copy link
Copy Markdown
Contributor

Description

  • reworked geometry commands files into the versioned architecture
  • matched with v1 server implementations for ease of future development

Issue linked

#1817

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Sep 17, 2025
@jacobrkerstetter
jacobrkerstetter requested a review from a team as a code owner September 17, 2025 14:59
jacobrkerstetter and others added 2 commits September 17, 2025 11:02
… feat/geometry_commands_restructure

# Conflicts:
#	src/ansys/geometry/core/designer/geometry_commands.py
@github-actions github-actions Bot added the enhancement New features or code improvements label Sep 17, 2025
@codecov

codecov Bot commented Sep 17, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.36275% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.61%. Comparing base (b50e559) to head (2c147db).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ys/geometry/core/_grpc/_services/v1/model_tools.py 69.56% 7 Missing ⚠️
...metry/core/_grpc/_services/v1/assembly_controls.py 70.58% 5 Missing ⚠️
...rc/ansys/geometry/core/_grpc/_services/v1/beams.py 70.58% 5 Missing ⚠️
...rc/ansys/geometry/core/_grpc/_services/_service.py 94.33% 3 Missing ⚠️
...ansys/geometry/core/_grpc/_services/v1/commands.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2234      +/-   ##
==========================================
- Coverage   94.74%   94.61%   -0.13%     
==========================================
  Files         142      157      +15     
  Lines       10631    10886     +255     
==========================================
+ Hits        10072    10300     +228     
- Misses        559      586      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go set by set... I simply reviewed the "beams" part for now and it requires a few fixes. Please address them and I'll move on to the next block. Reviewing this PR will take time

Comment thread src/ansys/geometry/core/designer/component.py Outdated
Comment thread src/ansys/geometry/core/designer/component.py Outdated
Comment thread src/ansys/geometry/core/designer/component.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v0/beams.py
Comment thread src/ansys/geometry/core/_grpc/_services/v0/beams.py
Comment thread src/ansys/geometry/core/_grpc/_services/v1/beams.py Outdated
@RobPasMue RobPasMue mentioned this pull request Sep 24, 2025
9 tasks done

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed Assembly Controls, Bodies and Commands (plus an extra Beams comment) -- looking good for now. Let's address these

Comment thread src/ansys/geometry/core/designer/component.py
Comment thread src/ansys/geometry/core/designer/component.py
Comment thread src/ansys/geometry/core/_grpc/_services/v0/bodies.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v1/bodies.py Outdated
Comment thread src/ansys/geometry/core/designer/geometry_commands.py

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third round as promised! Less to go!

Comment thread src/ansys/geometry/core/_grpc/_services/v0/commands.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v1/commands.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v0/edges.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v1/model_tools.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v0/model_tools.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v0/model_tools.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v0/model_tools.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v0/model_tools.py Outdated
Comment thread src/ansys/geometry/core/designer/geometry_commands.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v0/model_tools.py

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very similar comments to the previous stages - incredible job @jacobrkerstetter - we are almost there. After this review I will perform a global, quick review and we can merge

Comment thread src/ansys/geometry/core/_grpc/_services/v0/faces.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v1/faces.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v0/faces.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v0/faces.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v1/faces.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v0/patterns.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v0/patterns.py Outdated
Comment thread tests/integration/test_geometry_commands.py
Comment thread src/ansys/geometry/core/_grpc/_services/v0/patterns.py Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v0/patterns.py Outdated
@RobPasMue

RobPasMue commented Sep 25, 2025 •

Copy link
Copy Markdown
Member

Also - thanks a LOT for accepting actual quantities and measurable objects on the tools!! 🥳

jacobrkerstetter and others added 6 commits September 25, 2025 08:07
… feat/geometry_commands_restructure

# Conflicts:
#	src/ansys/geometry/core/_grpc/_services/base/bodies.py
#	src/ansys/geometry/core/_grpc/_services/v0/bodies.py
#	src/ansys/geometry/core/_grpc/_services/v1/bodies.py
RobPasMue
RobPasMue previously approved these changes Sep 25, 2025
@RobPasMue
RobPasMue enabled auto-merge (squash) September 25, 2025 15:57
@github-actions github-actions Bot added the maintenance Package and maintenance related label Sep 25, 2025
@RobPasMue
RobPasMue merged commit 538ff14 into main Sep 25, 2025
50 of 52 checks passed
@RobPasMue
RobPasMue deleted the feat/geometry_commands_restructure branch September 25, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants