feat: move geometry commands to versioned architecture - #2234
Conversation
… feat/geometry_commands_restructure # Conflicts: # src/ansys/geometry/core/designer/geometry_commands.py
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2234 +/- ##
==========================================
- Coverage 94.74% 94.61% -0.13%
==========================================
Files 142 157 +15
Lines 10631 10886 +255
==========================================
+ Hits 10072 10300 +228
- Misses 559 586 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… feat/geometry_commands_restructure
RobPasMue
left a comment
There was a problem hiding this comment.
Let's go set by set... I simply reviewed the "beams" part for now and it requires a few fixes. Please address them and I'll move on to the next block. Reviewing this PR will take time
|
Adding comment to keep track of modules reviewed:
|
RobPasMue
left a comment
There was a problem hiding this comment.
Reviewed Assembly Controls, Bodies and Commands (plus an extra Beams comment) -- looking good for now. Let's address these
RobPasMue
left a comment
There was a problem hiding this comment.
Third round as promised! Less to go!
…om/ansys/pyansys-geometry into feat/geometry_commands_restructure
RobPasMue
left a comment
There was a problem hiding this comment.
Very similar comments to the previous stages - incredible job @jacobrkerstetter - we are almost there. After this review I will perform a global, quick review and we can merge
|
Also - thanks a LOT for accepting actual quantities and measurable objects on the tools!! 🥳 |
… feat/geometry_commands_restructure # Conflicts: # src/ansys/geometry/core/_grpc/_services/base/bodies.py # src/ansys/geometry/core/_grpc/_services/v0/bodies.py # src/ansys/geometry/core/_grpc/_services/v1/bodies.py
Description
Issue linked
#1817
Checklist
feat: extrude circle to cylinder)