Skip to content

feat: pull commands pt. 1 - #2241

Merged
jacobrkerstetter merged 28 commits into
mainfrom
feat/pull_commands
Sep 26, 2025
Merged

feat: pull commands pt. 1#2241
jacobrkerstetter merged 28 commits into
mainfrom
feat/pull_commands

Conversation

@jacobrkerstetter

@jacobrkerstetter jacobrkerstetter commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

Description

Finalized pull commands pt. 1 story from TFS

  • offset_faces
  • revolve_edges

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

jacobrkerstetter and others added 15 commits September 10, 2025 13:19
@jacobrkerstetter
beam service implemented
4e3df20
@jacobrkerstetter
model_tools implemented
cdbf47a
@jacobrkerstetter
extrude faces/edges implemented
96693f5
@jacobrkerstetter
patterns implemented and tested
1c8b496
@jacobrkerstetter
moved face related geometry commands
b050f16
@jacobrkerstetter
more face/edge commands
f1418d7
@jacobrkerstetter
assembly controls and round info
d179f1b
@jacobrkerstetter
final commands
69eeee7
@jacobrkerstetter
Merge branch 'main' of https://github.com/ansys/pyansys-geometry into…
fb0dd89 
… feat/geometry_commands_restructure

# Conflicts:
#	src/ansys/geometry/core/designer/geometry_commands.py
@pre-commit-ci
chore: auto fixes from pre-commit hooks
efbb4d3
@pyansys-ci-bot
chore: adding changelog file 2234.added.md [dependabot-skip]
0f02715
@jacobrkerstetter
Merge branch 'main' of https://github.com/ansys/pyansys-geometry into…
c2f2d71 
… feat/geometry_commands_restructure
@jacobrkerstetter
offset_faces tested and working
72f4fa1
@jacobrkerstetter
added the rest of methods - may need to remove offset face curves
10b7493
@jacobrkerstetter
adding dict return typehint
517db56 
removing offset_face_curves
@jacobrkerstetter jacobrkerstetter self-assigned this Sep 19, 2025
@github-actions github-actions Bot added the enhancement New features or code improvements label Sep 19, 2025
@codecov

codecov Bot commented Sep 19, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.58%. Comparing base (76eb2aa) to head (d8d20d0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2241      +/-   ##
==========================================
+ Coverage   94.57%   94.58%   +0.01%     
==========================================
  Files         157      160       +3     
  Lines       10886    10919      +33     
==========================================
+ Hits        10295    10328      +33     
  Misses        591      591

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobrkerstetter
jacobrkerstetter marked this pull request as ready for review September 22, 2025 12:52
@jacobrkerstetter
jacobrkerstetter requested a review from a team as a code owner September 22, 2025 12:52
@github-actions github-actions Bot added the maintenance Package and maintenance related label Sep 22, 2025
@jacobrkerstetter
jacobrkerstetter marked this pull request as draft September 22, 2025 20:09
@github-actions github-actions Bot removed the maintenance Package and maintenance related label Sep 23, 2025
@jacobrkerstetter
jacobrkerstetter marked this pull request as ready for review September 23, 2025 20:00
@RobPasMue

RobPasMue commented Sep 24, 2025

Copy link
Copy Markdown
Member

We will wait for #2234 to be merged before proceeding with this PR

@github-actions github-actions Bot added the maintenance Package and maintenance related label Sep 26, 2025
RobPasMue
RobPasMue previously approved these changes Sep 26, 2025
View reviewed changes

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments - but LGTM!

Comment thread .github/workflows/ci_cd.yml Outdated
Comment thread src/ansys/geometry/core/_grpc/_services/v1/faces.py
Comment thread src/ansys/geometry/core/_grpc/_services/v0/faces.py Outdated
Comment thread src/ansys/geometry/core/designer/geometry_commands.py
Comment thread src/ansys/geometry/core/designer/geometry_commands.py
@jacobrkerstetter
jacobrkerstetter requested a review from a team September 26, 2025 13:31
RobPasMue
RobPasMue previously approved these changes Sep 26, 2025
View reviewed changes
@RobPasMue
RobPasMue enabled auto-merge (squash) September 26, 2025 13:32
@jacobrkerstetter
jacobrkerstetter enabled auto-merge (squash) September 26, 2025 13:38
@jacobrkerstetter
jacobrkerstetter merged commit 86bbb5c into main Sep 26, 2025
54 of 56 checks passed
@jacobrkerstetter
jacobrkerstetter deleted the feat/pull_commands branch September 26, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

@jacobrkerstetter jacobrkerstetter

Labels

enhancement New features or code improvements maintenance Package and maintenance related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacobrkerstetter @RobPasMue @pyansys-ci-bot