Skip to content

feat: loft profiles with guides - #2252

Merged
jacobrkerstetter merged 12 commits into
mainfrom
feat/loft_with_guides
Sep 25, 2025
Merged

jacobrkerstetter merged 12 commits into
mainfrom
feat/loft_with_guides

Conversation

@jacobrkerstetter

@jacobrkerstetter jacobrkerstetter commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Description

  • added method to support passing guide curves when lofting profiles

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions Bot added maintenance Package and maintenance related enhancement New features or code improvements labels Sep 24, 2025
@codecov

codecov Bot commented Sep 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.74%. Comparing base (0bfefb6) to head (409aa8d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2252   +/-   ##
=======================================
  Coverage   94.73%   94.74%           
=======================================
  Files         142      142           
  Lines       10615    10631   +16     
=======================================
+ Hits        10056    10072   +16     
  Misses        559      559           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobrkerstetter
jacobrkerstetter marked this pull request as ready for review September 24, 2025 16:39
@jacobrkerstetter
jacobrkerstetter requested a review from a team as a code owner September 24, 2025 16:39
@github-actions github-actions Bot removed the maintenance Package and maintenance related label Sep 25, 2025
RobPasMue
RobPasMue previously approved these changes Sep 25, 2025

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment - otherwise LGTM!

Comment thread src/ansys/geometry/core/_grpc/_services/v0/bodies.py Outdated
Comment thread src/ansys/geometry/core/designer/component.py Outdated
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
@jacobrkerstetter
jacobrkerstetter merged commit 6d62b4c into main Sep 25, 2025
52 checks passed
@jacobrkerstetter
jacobrkerstetter deleted the feat/loft_with_guides branch September 25, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants