Skip to content

chore: cleanup conversions module and remaining imports #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

chore: cleanup conversions module and remaining imports #2332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15b9b48
chore: cleanup conversions module and remaining imports
RobPasMue Oct 20, 2025
58978b6
Merge branch 'main' into chore/cleanup-before-release
RobPasMue Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/ansys/geometry/core/_grpc/_services/v0/named_selection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
from ansys.geometry.core.errors import protect_grpc

from ..base.named_selection import GRPCNamedSelectionService
from .conversions import build_grpc_id
from .conversions import build_grpc_id, from_grpc_point_to_point3d


class GRPCNamedSelectionServiceV0(GRPCNamedSelectionService):
Expand Down Expand Up @@ -64,7 +64,9 @@ def get_named_selection(self, **kwargs): # noqa: D102
"faces": [face.id for face in response.faces],
"edges": [edge.id for edge in response.edges],
"beams": [beam.id.id for beam in response.beams],
"design_points": [(dp.id, dp.points[0]) for dp in response.design_points],
"design_points": [
(dp.id, from_grpc_point_to_point3d(dp.points[0])) for dp in response.design_points
],
"components": [comp.id for comp in response.components],
"vertices": [vertex.id.id for vertex in response.vertices],
}
Expand Down
14 changes: 0 additions & 14 deletions src/ansys/geometry/core/connection/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,6 @@

from ansys.geometry.core.connection.backend import ApiVersions, BackendType
from ansys.geometry.core.connection.client import GrpcClient
from ansys.geometry.core.connection.conversions import (
curve_to_grpc_curve,
frame_to_grpc_frame,
grpc_curve_to_curve,
grpc_frame_to_frame,
grpc_matrix_to_matrix,
grpc_surface_to_surface,
line_to_grpc_line,
plane_to_grpc_plane,
point3d_to_grpc_point,
sketch_shapes_to_grpc_geometries,
trimmed_curve_to_grpc_trimmed_curve,
unit_vector_to_grpc_direction,
)
import ansys.geometry.core.connection.defaults as defaults
from ansys.geometry.core.connection.docker_instance import (
GeometryContainers,
Expand Down
Loading
Loading