-
Notifications
You must be signed in to change notification settings - Fork 22
chore: implement v1 for conversions.py #2403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Stub adjustments for v1. Currently missing is PartExportFormat which has been remove from API server (but should be added back)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2403 +/- ##
==========================================
- Coverage 95.08% 92.97% -2.11%
==========================================
Files 169 169
Lines 11343 11656 +313
==========================================
+ Hits 10785 10837 +52
- Misses 558 819 +261 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacobrkerstetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - let's get this in so we can start testing it with other methods. I will do a big cleanup/reorg at the end of v1 😃
Description
implement v1 for conversions.py.
Left out PartExportFormat which has been removed from the API server (but should be added back)
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder)