Skip to content

Conversation

@smereu
Copy link
Contributor

@smereu smereu commented Nov 21, 2025

Description

implement v1 for conversions.py.
Left out PartExportFormat which has been removed from the API server (but should be added back)

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

pyansys-ci-bot and others added 21 commits February 17, 2025 14:31
Stub adjustments for v1.
Currently missing is PartExportFormat which has been remove from API server (but should be added back)
@smereu smereu self-assigned this Nov 21, 2025
@smereu smereu requested a review from a team as a code owner November 21, 2025 21:51
@github-actions github-actions bot added the maintenance Package and maintenance related label Nov 21, 2025
@github-actions github-actions bot removed the maintenance Package and maintenance related label Nov 21, 2025
@github-actions github-actions bot added the maintenance Package and maintenance related label Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 16.87898% with 261 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.97%. Comparing base (2f6eb70) to head (af03b08).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ys/geometry/core/_grpc/_services/v1/conversions.py 16.87% 261 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2403      +/-   ##
==========================================
- Coverage   95.08%   92.97%   -2.11%     
==========================================
  Files         169      169              
  Lines       11343    11656     +313     
==========================================
+ Hits        10785    10837      +52     
- Misses        558      819     +261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jacobrkerstetter jacobrkerstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - let's get this in so we can start testing it with other methods. I will do a big cleanup/reorg at the end of v1 😃

@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Nov 24, 2025
@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) November 24, 2025 13:24
@jacobrkerstetter jacobrkerstetter merged commit b9c6369 into main Nov 24, 2025
50 of 51 checks passed
@jacobrkerstetter jacobrkerstetter deleted the ci/conversions_v0_to_v1 branch November 24, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants