Skip to content

refactor: deprecate element_ids attribute in Part class - #1150

Merged
mhoeijm merged 39 commits into
mainfrom
refactor/refactor-attributes-of-part
Jun 23, 2025
Merged

refactor: deprecate element_ids attribute in Part class#1150
mhoeijm merged 39 commits into
mainfrom
refactor/refactor-attributes-of-part

Conversation

@mhoeijm

@mhoeijm mhoeijm commented Jun 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Deprecates element_ids as an attribute of parts. Use the get_element_ids() method with a Mesh object and the parts pid instead.

This also modifies any methods that were just modifying element_ids in the Part class without modifying the mesh data in Mesh. This avoids inconsistencies between Part and Mesh.

@github-actions github-actions Bot added the tests Related with improvements of the test suite label Jun 20, 2025
pyansys-ci-bot and others added 23 commits June 20, 2025 18:37
@pyansys-ci-bot
chore: adding changelog file 1150.miscellaneous.md [dependabot-skip]
1dd6862
@mhoeijm
feat: property to get unused volume id
349dfdc
@mhoeijm
feat: return empty array if pid not defined
8bcb2da
@mhoeijm
feat: refactor create_part_by_ids to use cell data
b5a16e9
@mhoeijm
Merge branch 'refactor/refactor-attributes-of-part' of https://github…
7cd55af 
….com/ansys/pyansys-heart into refactor/refactor-attributes-of-part
@mhoeijm
feat: add assertion to test
1a6f045
@mhoeijm
feat: cleanup tests
2776f04
@mhoeijm
feat: refactor to use get_element_ids() method
453b620
@mhoeijm
feat: refactor to use get_element_ids() method
1f93057
@mhoeijm
feat: simplify create part by ids
bd63bc1
@mhoeijm
feat: remove reference in plotter
96bdf18
@mhoeijm
feat: remove reference from extract elements and get used elements
7a1bd72
@mhoeijm
feat: fix stiff ventricle base
664929b
@mhoeijm
feat: remove reference to _element_ids from validate parts
d04666d
@mhoeijm
feat: refactor and deprecate assign_elements_to_parts
ad673cc
@mhoeijm
feat: change to ints
ec7a58c
@mhoeijm
feat: refactor sync epicardium with part
485243c
@mhoeijm
feat: refactor create atrioventricular isolation
86ee0d5
@mhoeijm
feat: refactor create atrioventricular isolation
e95f138
@mhoeijm
feat: cleanup obsolete assignment of element_ids
90f7789
@mhoeijm
feat: fix plot part
f8daa6d
@mhoeijm
feat: validate pid in volume instead of assigning element ids
0cf6213
@mhoeijm
feat: refactor compute aha17
670d3cd
@mhoeijm
mhoeijm marked this pull request as ready for review June 23, 2025 12:42
@mhoeijm
mhoeijm requested a review from a team as a code owner June 23, 2025 12:42
@mhoeijm mhoeijm changed the title refactor: refactor attributes of part refactor: deprecate element_ids attribute of Part Jun 23, 2025
@mhoeijm mhoeijm changed the title refactor: deprecate element_ids attribute of Part refactor: deprecate element_ids attribute in Part class Jun 23, 2025
@github-actions github-actions Bot added the ci Pipelines maintenance related label Jun 23, 2025
@mhoeijm

mhoeijm commented Jun 23, 2025

Copy link
Copy Markdown
Contributor Author

fyi @wenfengye

@mhoeijm
mhoeijm merged commit 793253f into main Jun 23, 2025
@mhoeijm
mhoeijm deleted the refactor/refactor-attributes-of-part branch June 23, 2025 17:54
@mhoeijm mhoeijm linked an issue Jun 23, 2025 that may be closed by this pull request
Retrieving element_ids should be infered from the mesh and pid #1153
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci Pipelines maintenance related tests Related with improvements of the test suite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Retrieving element_ids should be infered from the mesh and pid

2 participants

@mhoeijm @pyansys-ci-bot