Skip to content

fix: refactor part id assignment post wrap - #946

Merged
mhoeijm merged 15 commits into
mainfrom
fix/refactor-part-id-assignment-post-wrap
Mar 24, 2025
Merged

mhoeijm merged 15 commits into
mainfrom
fix/refactor-part-id-assignment-post-wrap

Conversation

@mhoeijm

@mhoeijm mhoeijm commented Mar 19, 2025 •

Copy link
Copy Markdown
Contributor

Performance of the vtkImplicitPolyDataDistance filter is not great, but so far seems more robust than the vtkExtractEnclosedPoints filter.

  • 44/44 Rodero/Strocchi cases mesh ok and give a valid heart_model.vtu
  • Some cases failed on fiber generation, this seems resolved now
  • Most following EP simulations seem ok in terms of validity of the .k files

@github-actions github-actions Bot added the fix label Mar 19, 2025
@github-actions github-actions Bot added the fix label Mar 20, 2025
@github-actions github-actions Bot added fix and removed fix labels Mar 20, 2025
@mhoeijm
mhoeijm marked this pull request as ready for review March 20, 2025 12:31
@mhoeijm
mhoeijm requested a review from wenfengye March 20, 2025 12:31
Comment thread src/ansys/heart/core/helpers/vtk_utils.py

@wenfengye wenfengye left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this covered by any test already?

@mhoeijm

mhoeijm commented Mar 20, 2025

Copy link
Copy Markdown
Contributor Author

is this covered by any test already?

will do, it is in principle covered by test_model_generation but since this is not very strict in terms of mesh stats it will not capture changes in the methods very well (except if it really breaks methods downstream).

@github-actions github-actions Bot added fix and removed fix labels Mar 24, 2025
@github-actions github-actions Bot added fix and removed fix labels Mar 24, 2025
@mhoeijm
mhoeijm requested a review from wenfengye March 24, 2025 11:54
@github-actions github-actions Bot added the fix label Mar 24, 2025
@mhoeijm mhoeijm self-assigned this Mar 24, 2025
@mhoeijm
mhoeijm enabled auto-merge (squash) March 24, 2025 12:20
@github-actions github-actions Bot removed the fix label Mar 24, 2025
@mhoeijm
mhoeijm merged commit 1ae5aec into main Mar 24, 2025
@mhoeijm
mhoeijm deleted the fix/refactor-part-id-assignment-post-wrap branch March 24, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LSDYNA Fiber generation fails when elements are connected only with a single node

3 participants