Repository navigation
refactor: add method to get fluent ui-mode - #957
Merged
Merged
Conversation
mhoeijm
changed the title
…ys/pyansys-heart into refactor/get-fluent-gui-mode
jorgepiloto
requested changes
Mar 24, 2025
jorgepiloto
left a comment
jorgepiloto
left a comment
Member
There was a problem hiding this comment.
Suggesting to only add one environment variable.
added 3 commits
March 24, 2025 19:31
added 2 commits
March 24, 2025 19:46
Contributor
Author
|
Also fixes #947 |
This reverts commit e691a80.
jorgepiloto
approved these changes
Mar 25, 2025
jorgepiloto
left a comment
jorgepiloto
left a comment
Member
There was a problem hiding this comment.
Thanks for adding this, @mhoeijm. This is very flexible. Approving and merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jorgepiloto @moe-ad modifying how we obtain the fluent ui mode. Fluent ui mode can now be controlled through an environment variable and will default to
hidden_guiinstead ofno_gui. We can switch tono_guifor the self-hosted runner by settingPYFLUENT_UI_MODEtono_gui.edit: Please note that the
no_guioption pops up a cmd window that doesn't seem to close after finishing the (py)fluent session. Not sure it will be a problem on the self-hosted runner.