-
Notifications
You must be signed in to change notification settings - Fork 0
Doc/overall review #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
i didn't tested vale locally, but i think it was because the upgrade of the vale version and the directory is not reading properly. i can try to run locally. |
At least it ran OK in the CI/CD! |
|
@Revathyvenugopal162 I'll leave this issue with you! |
it was an issue from Microsoft packages and it is fixed by them. |
dce3946 to
5ce9fe5
Compare
|
@Revathyvenugopal162 I edited the |
|
Thank you @PipKat For the hard work. merging the PR. |
@Revathyvenugopal162 I moved the content from the README.MD file to the doc RST files. I also created a new README.RST file. Will the repo know to display it once this PR is merged. I couldn't find any place where the file to show for the repository was specified but was worried that a change might be needed for this. I have a few comments inline as well. Also, I can't run Vale locally. I get this message:
E100 [vocab] Runtime error
'ANSYS' does not exist
I used the
git clean -f -d -x doccommand to clean thedocdirectory, thinking it would fix the issue, but it didn't. Do you know what Vale can't find theANSYSdirectory, which is here: C:\AnsysDev\GitRepos\PyAnsys\pyansys-quarto-cheatsheet\doc\styles\config\vocabularies\ANSYS