From de6f080971c26c447cdff9d305ebaccb55fa6ace Mon Sep 17 00:00:00 2001 From: Philip Usher Date: Tue, 22 Jul 2025 09:33:33 +0100 Subject: [PATCH 1/3] added missing optional arguments for job start/create --- src/ansys/conceptev/core/app.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/ansys/conceptev/core/app.py b/src/ansys/conceptev/core/app.py index 68228dc1..837c8145 100644 --- a/src/ansys/conceptev/core/app.py +++ b/src/ansys/conceptev/core/app.py @@ -324,6 +324,8 @@ def create_submit_job( account_id: str, hpc_id: str, job_name: str | None = None, + docker_tag: str = "default", + extra_memory: bool = False, ) -> dict: """Create and then submit a job.""" if job_name is None: @@ -341,6 +343,8 @@ def create_submit_job( "uploaded_file": uploaded_file, "account_id": account_id, "hpc_id": hpc_id, + "docker_tag": docker_tag, + "extra_memory": extra_memory, } job_info = post(client, "/jobs:start", data=job_start, account_id=account_id) return job_info From 81b79eee51c01be6f0d5c2240d600b3d0a64af0c Mon Sep 17 00:00:00 2001 From: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Date: Tue, 22 Jul 2025 08:38:34 +0000 Subject: [PATCH 2/3] chore: adding changelog file 265.miscellaneous.md [dependabot-skip] --- doc/changelog.d/265.miscellaneous.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 doc/changelog.d/265.miscellaneous.md diff --git a/doc/changelog.d/265.miscellaneous.md b/doc/changelog.d/265.miscellaneous.md new file mode 100644 index 00000000..5186c545 --- /dev/null +++ b/doc/changelog.d/265.miscellaneous.md @@ -0,0 +1 @@ +Added missing optional arguments for job start/create \ No newline at end of file From 7c4c7fb52335f733e764c8848d64728269b294da Mon Sep 17 00:00:00 2001 From: Philip Usher Date: Tue, 22 Jul 2025 10:17:53 +0100 Subject: [PATCH 3/3] updated test --- tests/test_app.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/test_app.py b/tests/test_app.py index d46d0ea2..612e1da5 100644 --- a/tests/test_app.py +++ b/tests/test_app.py @@ -279,6 +279,8 @@ def test_create_submit_job(httpx_mock: HTTPXMock, client: httpx.Client): "uploaded_file": mocked_job[1], "account_id": account_id, "hpc_id": hpc_id, + "docker_tag": "default", + "extra_memory": False, } httpx_mock.add_response( url=f"{conceptev_url}/jobs:start?design_instance_id=123&account_id={account_id}",