Skip to content

feat: docker image for run#1069

Merged
koubaa merged 111 commits into
mainfrom
feat/docker-run
Feb 25, 2026
Merged

feat: docker image for run#1069
koubaa merged 111 commits into
mainfrom
feat/docker-run

Conversation

@Revathyvenugopal162
Copy link
Copy Markdown
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Jan 22, 2026

### Unified Docker Image for LS-DYNA with SMP/MPP Support

This PR introduces a unified Docker image for running LS-DYNA simulations through PyDyna's run module, containing both SMP and MPP executables in a single container with automatic mode
detection.

Changes

Docker Infrastructure

  • ✅ Consolidated SMP and MPP executables into a single Dockerfile
  • ✅ Added OpenMPI support for MPP runs
  • ✅ Automated FTP-based download of LS-DYNA executables during build
  • ✅ Removed legacy file.sh script
  • ✅ Updated docker/run/README.rst with comprehensive build and usage documentation

Docker Runner Enhancements

  • ✅ Implemented auto-detection to select SMP vs MPP executable based on solver options
  • ✅ Added executable discovery mechanism within container
  • ✅ Improved error handling and logging throughout
  • ✅ Added graceful handling for Docker SDK import
  • ✅ Enhanced environment variable management (OpenMPI flags, licensing)
  • ✅ Better container lifecycle management (create, execute, cleanup)

CI/CD Updates

  • ✅ Updated nightly CI workflow with Docker build matrix (SMP/MPP testing)
  • ✅ Added new publish-run-image.yml workflow for automated image publishing
  • ✅ Streamlined PR workflow Docker build steps
  • ✅ Removed unused doc-build action steps

Testing

  • ✅ Added comprehensive test suite in tests/test_docker_runner.py (461 lines)
  • ✅ Covers SMP/MPP modes, precision options, and error conditions

Dependencies

  • ✅ Added docker to project dependencies in pyproject.toml

Key Benefits

  • Eliminates SMP/MPP mode mismatch issues
  • Simplifies deployment with single unified image
  • Automatic executable selection reduces user configuration
  • Improved error handling and logging for troubleshooting

@github-actions github-actions Bot added enhancement General improvements to existing features testing Anything related to testing dependencies Related with project dependencies maintenance Generic maintenance related ci Pipelines maintenance related labels Jan 22, 2026
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review February 24, 2026 16:55
@Revathyvenugopal162 Revathyvenugopal162 requested a review from a team as a code owner February 24, 2026 16:55
Comment thread docker/run/Dockerfile Outdated
@koubaa koubaa merged commit 7cf1249 into main Feb 25, 2026
22 checks passed
@koubaa koubaa deleted the feat/docker-run branch February 25, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pipelines maintenance related dependencies Related with project dependencies enhancement General improvements to existing features maintenance Generic maintenance related testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants