fix: CONTROL_TIMESTEP and CONTROL_TIME_STEP (#629)#631
Merged
RaphaelHeiniger merged 5 commits intoDec 23, 2024
Merged
Conversation
…be generated. Removed it from the SKIPPED_KEYWORDS list. Removed it from manifest. Added test for CONTROL_TIMESTEP and edited test for CONTROL_TIME_STEP.
2 tasks
github-actions
Bot
added
documentation
Collaborator
Author
|
@RobPasMue can you advise me on how to label the pull request. Thanks. |
RaphaelHeiniger
changed the title
RobPasMue
reviewed
Nov 28, 2024
RobPasMue
left a comment
RobPasMue
left a comment
Member
There was a problem hiding this comment.
This PR should be labeled as an enhancement. Also, I'd leave it to the rest of the @ansys/pydyna team to review it since I am no expert on these modules...
RaphaelHeiniger
added
enhancement
koubaa
approved these changes
Dec 6, 2024
github-actions
Bot
added
the
documentation
Collaborator
|
@RaphaelHeiniger please go ahead and merge |
…-no-attribute-controltimestep
RaphaelHeiniger
deleted the
629-ansysdynacorekeywordskeyword_classes-has-no-attribute-controltimestep
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTROL_TIMESTEP, CONTROL_TIMESTEP is in the kwd.json now and should be generated. Removed it from the SKIPPED_KEYWORDS list. Removed it from manifest. Added test for CONTROL_TIMESTEP and edited test for CONTROL_TIME_STEP.