feat: add parameter set to lib#644
Merged
Merged
Conversation
github-actions
Bot
added
documentation
Collaborator
|
I don't see urgency for the functionality that the loader automatically processes *PARAMETER keywords and fills the parameters. I even think that most users parametrized their deck on purpose and want to keep their parametrized input deck. Sometimes the parameter file is even encrypted so the values of the parameters will not be accessible. If such an automatization is implemented we would definitely need an option to activate or deactivate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Begin on #641
Support for parameters is added to some card types. It is still the responsibility of the user to assign parameter values. That is, the loader does not automatically process *PARAMETER keywords and fill the parameters.
See the changes in
tests/test_deck.pyfor an example of how to use this.In the future, we will automatically process parameters in decks.