Skip to content

fix: The nan comparison in series card test - #804

Merged
koubaa merged 2 commits into
mainfrom
fix-series-card-test-python-3.13
May 2, 2025
Merged

fix: The nan comparison in series card test#804
koubaa merged 2 commits into
mainfrom
fix-series-card-test-python-3.13

Conversation

@koubaa

@koubaa koubaa commented May 2, 2025

Copy link
Copy Markdown
Collaborator

need to use math.isnanrather than compare nan with ==. This is more correct in all versions of python, but somehow only python3.13 caught it.

@koubaa
koubaa requested a review from Revathyvenugopal162 May 2, 2025 15:40
@koubaa
koubaa requested a review from a team as a code owner May 2, 2025 15:40
@github-actions github-actions Bot added testing Anything related to testing fix Pull requests related to resolving problems or errors labels May 2, 2025
@koubaa koubaa changed the title fix series card test fix: nan comparison in series card test May 2, 2025
@Revathyvenugopal162 Revathyvenugopal162 changed the title fix: nan comparison in series card test fix: The nan comparison in series card test May 2, 2025
@koubaa

koubaa commented May 2, 2025

Copy link
Copy Markdown
Collaborator Author

@Revathyvenugopal162 do you know how to restart the changelog fragment action? If I do it from he actions tab manually it doesn't pick up the new PR title. I had to close/reopen the PR to get the full CI to restart

@koubaa koubaa closed this May 2, 2025
@koubaa koubaa reopened this May 2, 2025
@Revathyvenugopal162

Copy link
Copy Markdown
Contributor

@Revathyvenugopal162 do you know how to restart the changelog fragment action? If I do it from he actions tab manually it doesn't pick up the new PR title. I had to close/reopen the PR to get the full CI to restart

I never tried this, usually with next commit it will recreate the changelog. Noted, I will investigate /enquire about this

@koubaa
koubaa merged commit 05f9652 into main May 2, 2025
@koubaa
koubaa deleted the fix-series-card-test-python-3.13 branch May 2, 2025 16:43
@koubaa

koubaa commented May 2, 2025

Copy link
Copy Markdown
Collaborator Author

@Revathyvenugopal162 do you know how to restart the changelog fragment action? If I do it from he actions tab manually it doesn't pick up the new PR title. I had to close/reopen the PR to get the full CI to restart

I never tried this, usually with next commit it will recreate the changelog. Noted, I will investigate /enquire about this

@Revathyvenugopal162 In this case there wasn't a "next commit", I just fixed the title of the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Pull requests related to resolving problems or errors testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants