Skip to content

Conversation

@hpohekar
Copy link
Collaborator

No description provided.

@hpohekar hpohekar linked an issue Oct 19, 2022 that may be closed by this pull request
@seanpearsonuk
Copy link
Collaborator

@hpohekar @mkundu1 should we rename quantity.py -> _quantity.py? Should we put a try - except ImportError around import pint in that module and show an appropriate message indicating need to install pint>0.18?

@hpohekar
Copy link
Collaborator Author

hpohekar commented Oct 19, 2022

@hpohekar @mkundu1 should we rename quantity.py -> _quantity.py? Should we put a try - except ImportError around import pint in that module and show an appropriate message indicating need to install pint>0.18?

Yes, we can rename it to _quantity.py also if needed we can put try-except ImportError because anyhow if pint is not there ultimately it will give standard ModuleNotFoundError as an error message.

@hpohekar hpohekar merged commit 82fa560 into main Oct 19, 2022
@hpohekar hpohekar deleted the maint/remove_pint_from_setup branch October 19, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove unnecessary pint dependency

5 participants