Fix nightly tests #1994
Merged
Fix nightly tests #1994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
commented
Sep 20, 2023
mkundu1
requested review from
ajain-work,
dnwillia-work,
h-krishnan,
hpohekar,
prmukherj,
raph-luc and
seanpearsonuk
as code owners
raph-luc
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Would it be more appropriate in the long term to add a pytest marker specific for tests/test_solvermode and then enable it in the suggested unittest-solvermode-241?
Regardless, this works fine I think, and the minor refactoring I suggest can easily be done at another time
prmukherj
approved these changes
Sep 20, 2023
seanpearsonuk
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests within tests/test_solvermode directory will now be run weekly through the new
weekly-solvermode-test-run.yml.