-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post processing with pyVista #21
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
646b0e1
Post processing with pyVista
ajain-work 5075c14
pyVista post processing
ajain-work 91eb370
pyVista post processing
ajain-work 9dfc579
pyVista post processing
ajain-work 378179f
pyVista post processing
ajain-work 1f34fe3
pyVista Post processing
ajain-work b7c9bb6
pyVista post processing
ajain-work 929aa45
pyVista post processing
ajain-work 81a4afe
pyVista Post processing
ajain-work 14416e7
pyVista Post processing
ajain-work f8354cc
pyVista Post processing
ajain-work 02f3e26
pyVista Post processing
ajain-work 4d6e060
Install pyvista for python-3.10 (#25)
mkundu1 ba9f6fc
Corrected Iso surface range
ajain-work 1cf424a
Merge branch 'feat/pyvista_postprocessing' of https://github.com/pyan…
ajain-work 76da8ec
Container to store collection
ajain-work 87dae43
Container to store collection
ajain-work 72f128d
Merge pull request #27 from pyansys/feat/postprocessing_container
ajain-work de79260
Corrected readme
ajain-work c3494cb
Specify pyvista whl in setup.py (#35)
mkundu1 7b22b39
PyVista Post processing
ajain-work 1a36a81
Merge branch 'feat/pyvista_postprocessing' of https://github.com/pyan…
ajain-work debc849
pyVista post processing
ajain-work e613239
pyVista post processing
ajain-work 9ab895d
PyVista Postprocessing
ajain-work ca6698a
Multi plotters support
ajain-work 1bd2af4
Multiple plotters
ajain-work 200da3e
Multiple plotters
ajain-work 9a4cc8a
Multiple plotters
ajain-work c124109
Multiple plotters
ajain-work 78991b9
Merge pull request #48 from pyansys/feat/multi_plotters_support
ajain-work File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
from ansys.fluent.postprocessing.pyvista.plotter import plotter # noqa: F401 | ||
from ansys.fluent.postprocessing.pyvista.graphics import Graphics # noqa: F401 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, what was causing the error. The naming looks ok. @ajain-ansys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class names should use CapWords convention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes and I'm not seeing why you need to ignore that error? It looks like you are using CapWords already. @ajain-ansys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I did not stare at it hard enough. It's because the member classes not following that naming convention.
Is there a reason the members are not following that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Member classes represent, object properties. We are not following CapWords convention for properties, because that is how we are accessing them. For example field for a contour object is accessed as: contour1.field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, ok, but I still don't understand. Is there any reason it can't be
contour1.Field
? For instance, is there is an external requirement driving this design choice? @ajain-ansysOK, sorry if I'm being dense, but Is it just that the other commands are all using lower case with underscores?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is correct. Other commands are all using lower case. For example, all commands in auto generated file tui.py are lower case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, very sorry, now I got it.