Skip to content

fix: Resolve MRO for _InputFile#3774

Merged
hpohekar merged 14 commits intomainfrom
fix/resolve_mro_for_input_file
Feb 26, 2025
Merged

fix: Resolve MRO for _InputFile#3774
hpohekar merged 14 commits intomainfrom
fix/resolve_mro_for_input_file

Conversation

@hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented Feb 25, 2025

closes #3775

Do not modify the class hierarchy dynamically which results in MRO conflicts.

Resolved - https://github.com/ansys/pyfluent/actions/runs/13513445674/job/37757855348

Latest workflow run - https://github.com/ansys/pyfluent/actions/runs/13520508995/job/37778526002

@github-actions github-actions bot added the bug Issue, problem or error in PyFluent label Feb 25, 2025
@hpohekar hpohekar marked this pull request as ready for review February 25, 2025 11:57
@hpohekar hpohekar requested a review from mkundu1 as a code owner February 25, 2025 11:57
@hpohekar hpohekar changed the title fix: resolve mro for _InputFile fix: Resolve MRO for _InputFile Feb 25, 2025
Copy link
Contributor

@mkundu1 mkundu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hpohekar Should we fix this in the codegen-side in a later version, so that file-like arguments are derived from classes having the file upload/download behaviour and avoid any runtime manipulation of the instances? We do something similar in flobject.py.

I'm approving the current PR as this looks to be an urgent fix that must go in for pyconsole.

@hpohekar
Copy link
Collaborator Author

@hpohekar Should we fix this in the codegen-side in a later version, so that file-like arguments are derived from classes having the file upload/download behaviour and avoid any runtime manipulation of the instances? We do something similar in flobject.py.

I'm approving the current PR as this looks to be an urgent fix that must go in for pyconsole.

@mkundu1 Yes, I agree because this is not happening in settings side. i.e. flobject.py

@hpohekar hpohekar merged commit cd2d434 into main Feb 26, 2025
34 checks passed
@hpohekar hpohekar deleted the fix/resolve_mro_for_input_file branch February 26, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyFluent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve mro for _InputFile

4 participants