From 658245add14741c85cf83da03acbe7153ddde6d1 Mon Sep 17 00:00:00 2001 From: Mainak Kundu Date: Tue, 11 Nov 2025 15:10:34 -0500 Subject: [PATCH 1/5] feta: Log from container when health-check fails --- src/ansys/fluent/core/fluent_connection.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/ansys/fluent/core/fluent_connection.py b/src/ansys/fluent/core/fluent_connection.py index 24fbb2b5137..b6cc00502cd 100644 --- a/src/ansys/fluent/core/fluent_connection.py +++ b/src/ansys/fluent/core/fluent_connection.py @@ -451,7 +451,13 @@ def __init__( # throws, we should not proceed. # TODO: Show user-friendly error message. if pyfluent.config.check_health: - self._health_check.check_health() + try: + self._health_check.check_health() + except Exception as ex: + if inside_container: + logger.error("Error reported from Fluent:") + logger.error(container.logs(stdout=False).decode()) + raise ex self._slurm_job_id = slurm_job_id From 65a0b06f96256052400498b779ea5acae6582cb7 Mon Sep 17 00:00:00 2001 From: Mainak Kundu <94432368+mkundu1@users.noreply.github.com> Date: Tue, 11 Nov 2025 15:25:49 -0500 Subject: [PATCH 2/5] Update src/ansys/fluent/core/fluent_connection.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- src/ansys/fluent/core/fluent_connection.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ansys/fluent/core/fluent_connection.py b/src/ansys/fluent/core/fluent_connection.py index b6cc00502cd..39f4760147e 100644 --- a/src/ansys/fluent/core/fluent_connection.py +++ b/src/ansys/fluent/core/fluent_connection.py @@ -456,7 +456,7 @@ def __init__( except Exception as ex: if inside_container: logger.error("Error reported from Fluent:") - logger.error(container.logs(stdout=False).decode()) + logger.error(container.logs(stdout=False).decode('utf-8', errors='replace')) raise ex self._slurm_job_id = slurm_job_id From aa701f7f7bd9edbbd2fe7d06e864ac8ea3c6cf4d Mon Sep 17 00:00:00 2001 From: Mainak Kundu Date: Tue, 11 Nov 2025 15:29:27 -0500 Subject: [PATCH 3/5] feat: Log from container when health-check fails --- src/ansys/fluent/core/fluent_connection.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/ansys/fluent/core/fluent_connection.py b/src/ansys/fluent/core/fluent_connection.py index 39f4760147e..d71927bc04b 100644 --- a/src/ansys/fluent/core/fluent_connection.py +++ b/src/ansys/fluent/core/fluent_connection.py @@ -453,10 +453,12 @@ def __init__( if pyfluent.config.check_health: try: self._health_check.check_health() - except Exception as ex: + except RuntimeError as ex: if inside_container: logger.error("Error reported from Fluent:") - logger.error(container.logs(stdout=False).decode('utf-8', errors='replace')) + logger.error( + container.logs(stdout=False).decode("utf-8", errors="replace") + ) raise ex self._slurm_job_id = slurm_job_id From 852bf21692cb85b3d8d2b69250d64892fba07512 Mon Sep 17 00:00:00 2001 From: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Date: Tue, 11 Nov 2025 20:32:15 +0000 Subject: [PATCH 4/5] chore: adding changelog file 4599.added.md [dependabot-skip] --- doc/changelog.d/4599.added.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 doc/changelog.d/4599.added.md diff --git a/doc/changelog.d/4599.added.md b/doc/changelog.d/4599.added.md new file mode 100644 index 00000000000..a2a60acc41c --- /dev/null +++ b/doc/changelog.d/4599.added.md @@ -0,0 +1 @@ +Log from container when health-check fails From 23356bde39e1d0e8a5a81d2ca54c02ae7cd7fb81 Mon Sep 17 00:00:00 2001 From: Mainak Kundu Date: Tue, 11 Nov 2025 15:32:13 -0500 Subject: [PATCH 5/5] feat: Log from container when health-check fails --- src/ansys/fluent/core/fluent_connection.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ansys/fluent/core/fluent_connection.py b/src/ansys/fluent/core/fluent_connection.py index d71927bc04b..bdbc8d94864 100644 --- a/src/ansys/fluent/core/fluent_connection.py +++ b/src/ansys/fluent/core/fluent_connection.py @@ -453,13 +453,13 @@ def __init__( if pyfluent.config.check_health: try: self._health_check.check_health() - except RuntimeError as ex: + except RuntimeError: if inside_container: logger.error("Error reported from Fluent:") logger.error( container.logs(stdout=False).decode("utf-8", errors="replace") ) - raise ex + raise self._slurm_job_id = slurm_job_id