Skip to content

Conversation

@dnwillia-work
Copy link
Collaborator

@dnwillia-work dnwillia-work commented Sep 11, 2022

  • processor_count is removed from the options .json since it's handled by the scheduler module. Scheduler machine allocations are clamped to this value if it is provided to launch_fluent and is less than the total allocated cores.
  • load_machines always returns a MachineList object now. Previously returned a vanilla list object in some cases which made testing a bit inconvenient.
  • If -tN or -cnf=<list> are provided as addtional_arguments to launch_fluent then load_machines is skipped, allowing for library users to over-ride the automatic treatment.
  • Fixed a bug in the scheduler unit tests. CCP_NODES was not cleaned up in the environment which can lead to subsequent test failures.

@dnwillia-work
Copy link
Collaborator Author

Still debugging why the codegen step in the unit tests build will not run. It seems to run fine locally so maybe I've broken something to do with connection to the container.

@dnwillia-work dnwillia-work linked an issue Sep 12, 2022 that may be closed by this pull request
@dnwillia-work dnwillia-work merged commit 3239b81 into main Sep 13, 2022
@dnwillia-work dnwillia-work deleted the feat/scheduler branch September 13, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Job scheduling via PyFluent

4 participants